From: "Pedersen, Thomas" <c_tpeder@qca.qualcomm.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
<ath6kl-devel@qualcomm.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath6kl: protect firmware from excessive WoW pattern length
Date: Mon, 20 Aug 2012 13:33:32 -0700 [thread overview]
Message-ID: <20120820203331.GA31777@pista> (raw)
In-Reply-To: <50328B3F.3070206@qca.qualcomm.com>
On Mon, Aug 20, 2012 at 10:08:47PM +0300, Kalle Valo wrote:
> > Can you revert this patch? Otherwise the followup will just do the same.
>
> I can revert the patch. But IMHO the check isn't that bad, and even
> cfg80211 can be buggy sometimes ;)
>
Well it's probably better not to cover any cfg80211 bugs up in the
driver anyway.
> >> And ath6kl even uses different define pattern_max_len:
> >>
> >> wiphy->wowlan.pattern_max_len = WOW_PATTERN_SIZE;
> >>
> >> But the value is still same:
> >>
> >> #define WOW_PATTERN_SIZE 64
> >> #define WOW_MASK_SIZE 64
> >>
> >> Thomas, can you please check this? Do we really need two different
> >> defines? And which one is the correct one here?
> >
> > No AFAICT there is no reason to have two different defines. I can submit
> > a small patch consolidating these, but it would remove the above hunk
> > anyway so I need to know whether you'll revert or not.
>
> Thanks. I'll revert the patch so please prepare your patch without the
> check.
OK.
Thomas
prev parent reply other threads:[~2012-08-20 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 0:15 [PATCH] ath6kl: protect firmware from excessive WoW pattern length Thomas Pedersen
2012-08-20 7:09 ` Kalle Valo
2012-08-20 7:13 ` Johannes Berg
2012-08-20 7:29 ` Kalle Valo
2012-08-20 18:18 ` Pedersen, Thomas
2012-08-20 19:08 ` Kalle Valo
2012-08-20 20:33 ` Pedersen, Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820203331.GA31777@pista \
--to=c_tpeder@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.