From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver Date: Tue, 21 Aug 2012 15:42:45 +0300 Message-ID: <20120821124243.GG10347@arwen.pp.htv.fi> References: <1345545940-2232-1-git-send-email-sourav.poddar@ti.com> <1345545940-2232-2-git-send-email-sourav.poddar@ti.com> <20120821124146.GA21557@sirena.org.uk> Reply-To: balbi@ti.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J1ldk4ymECC/Y9sn" Return-path: Received: from na3sys009aog110.obsmtp.com ([74.125.149.203]:36419 "EHLO na3sys009aog110.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754887Ab2HUMqo (ORCPT ); Tue, 21 Aug 2012 08:46:44 -0400 Received: by lbbgg13 with SMTP id gg13so823345lbb.41 for ; Tue, 21 Aug 2012 05:46:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120821124146.GA21557@sirena.org.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mark Brown Cc: Sourav Poddar , devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org --J1ldk4ymECC/Y9sn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote: > > + regmap_read(smsc->regmap, SMSC_DEV_ID, &ret); > > + dev_dbg(&i2c->dev, "SMSC Device ID: %d\n", ret); >=20 > I'd make these log messages dev_info() or something. dev_info() ? It'lll just make boot noisier for no good reason. Which user wants to see this during boot up ? That's a debugging feature for develop IMHO. --=20 balbi --J1ldk4ymECC/Y9sn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJQM4JDAAoJEIaOsuA1yqREyHgP/2209InzsuTouGTtyopqRUTI 8KAx2RzoVLNcP0qwGyEDd8jNyYXpcp5x4uwNsSRn3tL8zMC6RWuDl7LtWGTs7pBC hn4x2sEOw0IP1jVYjDucX6FICxpXO3sxG3THFU4f6Yu4LvNFZI30mDL1qkd9Dvzj 71v33lfamXo9QIZJJqUBjNvHy5I4LX8R22kP/0x9DyrBHNcOSq0GWQ0KGqiwEY9V OVwsMk5zXnntU1cbj803MIgCQNsVDyJZnFpng6G8/rgcnzQHd7X2tFG/NyMbVpfz IrdDLeKpomui8zO7L3nVRdoofauekL4s61gNWb6Zc8Q4FrSfn/qyNZtO9xXHwdJ9 pBl+Fit18uSWjpG5TLj5NxehpbBe6Gr3+V9wpGb8v8TGdOLn2M+mkKWplnl1yOaB ohKeSyrCH1W8szrDp8xQK60h61LPS1hcY8wfQIMQTPkqxtZ5lQ1ipaD1bIllGbDf V97Xy0peYc9Oz9PTvT5ktPQAQ6YOZkJPAoZ8FnOD9qlevQ4W2IQBjulY8FSvIV1l bRBayJYEfjF/wcrB9bBTqfMCKc4Q8MgbP9nHxuHvokNEbd2/QJDCpn3DnPNu+7iK jSjPPqKW99Kp9OIvgDPDD9k8erK1a3xASf+ZAJ3GsLMgnYo1Qf/AuB1gX8ueX6Wy UVrH7jQNDoVUY5S/J8LE =oLTt -----END PGP SIGNATURE----- --J1ldk4ymECC/Y9sn-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: balbi@ti.com (Felipe Balbi) Date: Tue, 21 Aug 2012 15:42:45 +0300 Subject: [PATCH 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver In-Reply-To: <20120821124146.GA21557@sirena.org.uk> References: <1345545940-2232-1-git-send-email-sourav.poddar@ti.com> <1345545940-2232-2-git-send-email-sourav.poddar@ti.com> <20120821124146.GA21557@sirena.org.uk> Message-ID: <20120821124243.GG10347@arwen.pp.htv.fi> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 21, 2012 at 01:41:46PM +0100, Mark Brown wrote: > > + regmap_read(smsc->regmap, SMSC_DEV_ID, &ret); > > + dev_dbg(&i2c->dev, "SMSC Device ID: %d\n", ret); > > I'd make these log messages dev_info() or something. dev_info() ? It'lll just make boot noisier for no good reason. Which user wants to see this during boot up ? That's a debugging feature for develop IMHO. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: