From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata
Date: Tue, 21 Aug 2012 13:23:39 +0200 [thread overview]
Message-ID: <20120821132339.45b28565@skate> (raw)
In-Reply-To: <1345057226-18726-2-git-send-email-stefan.froberg@petroprogram.com>
Le Wed, 15 Aug 2012 22:00:26 +0300,
Stefan Froberg <stefan.froberg@petroprogram.com> a ?crit :
> +ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y)
> + HOST_PYTHON_CONF_OPT += --disable-unicodedata
> +else
> + HOST_PYTHON_CONF_OPT += --enable-unicodedata
> +endif
No, this is not correct. The BR2_PACKAGE_* options are here to
configure the *target* packages. Host packages that are only
dependencies to build target packages do not have kconfig options. So
in this case, the only solution is to simply use --enable-unicodedata
unconditionally to the host-python build.
Can you post an updated patch with this change?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-08-21 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 19:00 [Buildroot] [PATCH] python: firefox host-python dependency needs --enable-unicodedata Stefan Froberg
2012-08-15 19:00 ` Stefan Froberg
2012-08-21 11:23 ` Thomas Petazzoni [this message]
2012-08-21 13:37 ` Stefan Fröberg
-- strict thread matches above, loose matches on Subject: below --
2012-08-21 13:48 Stefan Froberg
2012-08-24 21:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821132339.45b28565@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.