All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Michael Wang <wangyun@linux.vnet.ibm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Yinghai Lu <yinghai@kernel.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: BUG: scheduling while atomic, under native_smp_prepare_cpus()
Date: Wed, 22 Aug 2012 00:50:06 +0800	[thread overview]
Message-ID: <20120821165006.GA24559@localhost> (raw)
In-Reply-To: <5032067E.20505@linux.vnet.ibm.com>

On Mon, Aug 20, 2012 at 05:42:22PM +0800, Michael Wang wrote:
> On 08/20/2012 05:27 PM, Fengguang Wu wrote:
> > Hi Michael,
> > 
> > On Mon, Aug 20, 2012 at 05:20:35PM +0800, Michael Wang wrote:
> >> On 08/17/2012 09:49 PM, Fengguang Wu wrote:
> >>
> >> Hi, FengGuang
> >>
> >> native_smp_prepare_cpus has already disabled the preempt before
> >> reach __irq_alloc_descs(), and sleep in mutex_lock() cause the bug.
> >>
> >> May be the follow patch could help to solve the issue(actually I
> >> think the true problem should be in _cond_resched...).
> > 
> > Is this a debug patch? Since what it does is to conditionally disable
> > the warning.
> 
> No, I use this as a solution, it should work as the bug reported in boot
> process before init_post called.
> 
> We have some reference from __might_sleep which also avoid the check if
> system has not fully booted, so I think this way is acceptable, but I'm
> not the one to make decision...

Fair enough.

> > 
> >> I can't do test by my self since I can't reproduce the issue on my
> >> machine, the kernel_init thread never got a need sched flag set at
> >> that moment in my case...
> > 
> > I'll try it and report back :)
> 
> Appreciate :)

It works! :)

Tested-by: Fengguang Wu <wfg@linux.intel.com>

Thanks,
Fengguang

  reply	other threads:[~2012-08-21 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 13:49 BUG: scheduling while atomic, under native_smp_prepare_cpus() Fengguang Wu
2012-08-20  9:20 ` Michael Wang
2012-08-20  9:27   ` Fengguang Wu
2012-08-20  9:42     ` Michael Wang
2012-08-21 16:50       ` Fengguang Wu [this message]
2012-08-22  2:07         ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120821165006.GA24559@localhost \
    --to=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=wangyun@linux.vnet.ibm.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.