All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@bitmath.se>
To: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Cc: linux-input@vger.kernel.org,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@enac.fr>,
	Jiri Kosina <jkosina@suse.cz>
Subject: Re: QUANTA touchscreen controller integrated in HP2310ti no longer recognised (regression in 3.5 and later as compared to 3.3)
Date: Tue, 21 Aug 2012 21:06:26 +0200	[thread overview]
Message-ID: <20120821190626.GA1260@polaris.bitmath.org> (raw)
In-Reply-To: <1700293.Y8yBuPUG33@f17simon>

Hi Simon,

> We're going through our collection of touch screens, making sure that they all 
> work with current kernels, and we've found one that doesn't work with today's 
> Linus master.
> 
> lsusb describes the screen as:
> Bus 006 Device 002: ID 0408:3001 Quanta Computer, Inc. Optical Touch Screen

What about 0408:3008, does that one work?

> Any ideas on the best way to resolve this regression?

What does 'cat /sys/bus/hid/devices/0003:0408:3001.0001/modalias' say?

The patch below ought to be enough to make it work, although it is
still unclear why it is needed.

Thanks,
Henrik

---

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index bd4bc3c..2b775c3 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -963,7 +963,7 @@ static const struct hid_device_id mt_devices[] = {
                MT_USB_DEVICE(USB_VENDOR_ID_QUANTA,
                        USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH) },
        { .driver_data = MT_CLS_CONFIDENCE_CONTACT_ID,
-               MT_USB_DEVICE(USB_VENDOR_ID_QUANTA,
+               HID_USB_DEVICE(USB_VENDOR_ID_QUANTA,
                        USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001) },
        { .driver_data = MT_CLS_CONFIDENCE_CONTACT_ID,
                MT_USB_DEVICE(USB_VENDOR_ID_QUANTA,

       reply	other threads:[~2012-08-21 19:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1700293.Y8yBuPUG33@f17simon>
2012-08-21 19:06 ` Henrik Rydberg [this message]
2012-08-22  9:00   ` QUANTA touchscreen controller integrated in HP2310ti no longer recognised (regression in 3.5 and later as compared to 3.3) Simon Farnsworth
2012-08-22  9:40     ` Simon Farnsworth
2012-08-22 17:04     ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120821190626.GA1260@polaris.bitmath.org \
    --to=rydberg@bitmath.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=benjamin.tissoires@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=simon.farnsworth@onelan.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.