Re: [PATCH] spi: Master driver for NXP SC18IS602/603

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1: Type: text/plain, Size: 975 bytes --]

On Wed, Aug 22, 2012 at 12:19:59PM -0700, Guenter Roeck wrote:
> On Wed, Aug 22, 2012 at 07:32:30PM +0100, Mark Brown wrote:

> > This feels like the wrong thing to do here: given that the user needs to
> > explicitly ask for the device to be instantiated we really ought to be
> > one the right bus so this should be more of an error.  Not sure what I
> > can constructively sugget except for an error message and perhaps
> > returning -EINVAL though.

> Makes sense. Changing the return value to -EINVAL results in the following
> warning message from the driver subsystem.

> sc18is602: probe of 7-0010 failed with error -22

> I think this should be good enough, as there are other possible reasons for the
> call to fail which result in similar messages. Do you want to make that change,
> or should I change it and resubmit ?

The above looks good, we don't need to go overboard - so long as it's
not a silent fail I think we're OK.  Please send an incremental change.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]