From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ns1.pc-advies.be ([83.149.101.17]:53011 "EHLO spo001.leaseweb.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755450Ab2HVTvH (ORCPT ); Wed, 22 Aug 2012 15:51:07 -0400 Date: Wed, 22 Aug 2012 21:25:25 +0200 From: Wim Van Sebroeck Subject: Re: [PATCH 38/74] lto, watchdog/hpwdt.c: Make assembler label global Message-ID: <20120822192525.GE27604@spo001.leaseweb.com> References: <1345345030-22211-1-git-send-email-andi@firstfloor.org> <1345345030-22211-39-git-send-email-andi@firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1345345030-22211-39-git-send-email-andi@firstfloor.org> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Andi Kleen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mmarek@suse.cz, linux-kbuild@vger.kernel.org, JBeulich@suse.com, akpm@linux-foundation.org, Andi Kleen , Thomas Mingarelli Hi andi, > From: Andi Kleen > > We cannot assume that the inline assembler code always ends up > in the same file as the original C file. So make any assembler labels > that are called with "extern" by C global > > Cc: wim@iguana.be > Signed-off-by: Andi Kleen You have my signed-off-by, but I'm Cc-ing also the author of the driver (Tom Mingarelli) so that he is also aware of the proposed change. Kind regards, Wim.