All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benoît Canet" <benoit.canet@irqsave.net>
To: Eric Blake <eblake@redhat.com>
Cc: aliguori@us.ibm.com, "Benoît Canet" <benoit.canet@gmail.com>,
	stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	pbonzini@redhat.com, xiawenc@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo.
Date: Thu, 23 Aug 2012 09:34:40 +0200	[thread overview]
Message-ID: <20120823073440.GA2330@irqsave.net> (raw)
In-Reply-To: <5034E6A2.7060900@redhat.com>

> > +##
> > +# @ImageInfo:
> > +#
> > +# Information about a QEMU image file
> > +#
> > +# @filename: name of the image file
> > +#
> > +# @format: format of the image file
> > +#
> > +# @virtual-size: maximum capacity in bytes of the image
> > +#
> > +# @actual-size: #optional actual size on disk in bytes of the image
> 
> That seems backwards - with a raw file, don't you know the actual size,
> but have no idea what it can further grow to?
Try the current qemy-img info on a raw file you will be surprised of the results.
This field also can have an "unavailable" value.

example result with unpatched qemu-img:

benoit@Laure:~/qemu$ qemu-img info truc1.raw 
image: truc1.raw
file format: raw
virtual size: 1.0G (1073741824 bytes)
disk size: 776M

disk size is actual-size.

Benoît

  parent reply	other threads:[~2012-08-23  7:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 12:45 [Qemu-devel] [PATCH V4 0/2] Add JSON output to qemu-img info Benoît Canet
2012-08-22 12:45 ` [Qemu-devel] [PATCH V4 1/2] qapi: Add SnapshotInfo and ImageInfo Benoît Canet
2012-08-22 14:03   ` Eric Blake
2012-08-22 14:32     ` Benoît Canet
2012-08-22 14:56       ` Eric Blake
2012-08-22 15:51         ` Benoît Canet
2012-08-23  7:34     ` Benoît Canet [this message]
2012-08-23  7:38     ` Benoît Canet
2012-08-22 12:45 ` [Qemu-devel] [PATCH V4 2/2] qemu-img: Add json output option to the info command Benoît Canet
2012-08-22 14:26   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120823073440.GA2330@irqsave.net \
    --to=benoit.canet@irqsave.net \
    --cc=aliguori@us.ibm.com \
    --cc=benoit.canet@gmail.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.