From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() Date: Thu, 23 Aug 2012 06:13:29 -0300 Message-ID: <20120823091329.GA32710@amt.cnet> References: <1345028893-2388-1-git-send-email-peter.maydell@linaro.org> <5033449B.40400@siemens.com> <503362A7.4010106@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peter Maydell , "patches@linaro.org" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Avi Kivity To: Jan Kiszka Return-path: Content-Disposition: inline In-Reply-To: <503362A7.4010106@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On Tue, Aug 21, 2012 at 12:27:51PM +0200, Jan Kiszka wrote: > On 2012-08-21 10:25, Peter Maydell wrote: > > On 21 August 2012 09:19, Jan Kiszka wrote: > >> On 2012-08-15 13:08, Peter Maydell wrote: > >>> Move the init of the irqchip_inject_ioctl field of KVMState out of > >>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() > >>> can be used even when no irqchip is created (for architectures > >>> that support async interrupt notification even without an in > >>> kernel irqchip). > > > >> As it's not yet merged, some late comment: irqchip_inject_ioctl should > >> be renamed as well. irq_inject_ioctl? > > > > If we're changing it anyway, IIRC Avi didn't like the term "inject" > > here? > > Then irq_set_ioctl. > > Jan It is merged, please send a follow patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4W7O-000487-0U for qemu-devel@nongnu.org; Thu, 23 Aug 2012 08:02:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4W7I-00089t-3a for qemu-devel@nongnu.org; Thu, 23 Aug 2012 08:02:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4W7H-00089d-S0 for qemu-devel@nongnu.org; Thu, 23 Aug 2012 08:02:28 -0400 Date: Thu, 23 Aug 2012 06:13:29 -0300 From: Marcelo Tosatti Message-ID: <20120823091329.GA32710@amt.cnet> References: <1345028893-2388-1-git-send-email-peter.maydell@linaro.org> <5033449B.40400@siemens.com> <503362A7.4010106@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <503362A7.4010106@siemens.com> Subject: Re: [Qemu-devel] [PATCH v2] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Peter Maydell , "patches@linaro.org" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , Avi Kivity On Tue, Aug 21, 2012 at 12:27:51PM +0200, Jan Kiszka wrote: > On 2012-08-21 10:25, Peter Maydell wrote: > > On 21 August 2012 09:19, Jan Kiszka wrote: > >> On 2012-08-15 13:08, Peter Maydell wrote: > >>> Move the init of the irqchip_inject_ioctl field of KVMState out of > >>> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() > >>> can be used even when no irqchip is created (for architectures > >>> that support async interrupt notification even without an in > >>> kernel irqchip). > > > >> As it's not yet merged, some late comment: irqchip_inject_ioctl should > >> be renamed as well. irq_inject_ioctl? > > > > If we're changing it anyway, IIRC Avi didn't like the term "inject" > > here? > > Then irq_set_ioctl. > > Jan It is merged, please send a follow patch.