From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Date: Thu, 23 Aug 2012 10:22:17 +0100 Message-ID: <20120823092216.GA27264@gmail.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <002801cd7c31$14d3d0c0$3e7b7240$@se> <20120820085111.GJ8450@gmail.com> <006d01cd7f5a$65937840$30ba68c0$@se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ey0-f179.google.com (mail-ey0-f179.google.com [209.85.215.179]) by alsa0.perex.cz (Postfix) with ESMTP id 023772661C2 for ; Thu, 23 Aug 2012 11:22:20 +0200 (CEST) Received: by eaa13 with SMTP id 13so117007eaa.38 for ; Thu, 23 Aug 2012 02:22:20 -0700 (PDT) Content-Disposition: inline In-Reply-To: <006d01cd7f5a$65937840$30ba68c0$@se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: broonie@opensource.wolfsonmicro.com, Ola Lilja Cc: roger.xr.nilsson@stericsson.com, 'Linus Walleij' , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org TWFyaywKCj4gPiA+IEknbSBzb3JyeSBidXQgdGhpcyBwYXRjaCBpcyBicmVha2luZyB0aGUgZGVz aWduIG9mIEFTb0MuCj4gPiA+IFRoZSBBU29DLXBsYXRmb3JtIGlzIHRoZSBETUEtYmxvY2sgKGlu IGNvbWJpbmF0aW9uIHdpdGggdGhlCj4gPiA+IE1TUC1ibG9jayksIGFuZCB0aGVyZSBzaG91bGQg YmUgYSBwbGF0Zm9ybS1kcml2ZXIgZm9yIHRoZSBETUEvUENNLgo+ID4gPiBUaGUKPiA+ID4gcGxh dGZvcm0tZHJpdmVyIHRoZW4gaGFzIGEgREFJIHdoaWNoIGlzIHRoZSBNU1AuIFRoZSBBU29DCj4g PiA+IERBSS1saW5rLXN0cnVjdCBzaG91bGQgaGF2ZSBvbmUgZHJpdmVyIGZvciBlYWNoIG9mIHRo ZXNlLCBzbyB0aGUKPiA+ID4gZHVtbXktZHJpdmVyIGZvciBQQ00gc2hvdWxkIGJlIHRoZXJlLgo+ ID4gCj4gPiBKdXN0IHRoaW5raW5nIGFib3V0IHRoaXMgbm93LiBJIGNvbnZlcnRlZCBpdCB0byB0 aGUgY3VycmVudCBmb3JtYXQgYXQKPiA+IHRoZSByZXF1ZXN0IG9mIE1hcmsuIElmIHRoaXMgaXNu J3QgdGhlIGNvcnJlY3QgbWV0aG9kIEknbSBub3QgcXVpdGUKPiA+IHN1cmUgd2hhdCBpcy4gSWYg eW91IHdhbnQgaXQgdG8gYmUgcmVnaXN0ZXJlZCBhcyBhIGRldmljZSwgdGhlbiBpdAo+ID4gbmVl ZHMgdG8gZ28gaW50byB0aGUgRGV2aWNlIFRyZWUsIGJ1dCBNYXJrIGRvZXNuJ3Qgd2FudCBpdCBp biB0aGVyZQo+ID4gYmVjYXVzZSBpdCBkb2Vzbid0IGFjdHVhbGx5IHJlcHJlc2VudCBoYXJkd2Fy ZS4KCkkndmUganVzdCB0YWtlbiBhIGNsb3NlciBsb29rIGF0IHRoaXMgd2l0aCBhIHZpZXcgdG8g ZmluZGluZyB0aGUgbW9zdApzdWl0YWJsZSBzb2x1dGlvbi4gTXkgY29uY2x1c2lvbiBpcyB0aGF0 IGFsdGhvdWdoIHRoZSBQQ00gZG9lc24ndApjb250YWluIGFueSByZWdpc3RlcnMsIG9yIHJlcHJl c2VudCBoYXJkd2FyZSBpdCBzaG91bGQgYmUgYSBkZXZpY2UgYW5kCnRoZXJlZm9yZSBiZSBwcmVz ZW50IGluIHRoZSBEZXZpY2UgVHJlZS4KClRoZXNlIGFyZSBteSBmaW5kaW5nczoKClBDTSBkZXZp Y2VzIGFscmVhZHkgcmVwcmVzZW50ZWQgaW4gRFRzOgogIGZzbCxtcGM1MjAwLXBjbSAtIHdyaXR0 ZW4gYnkgR3JhbnQgTGlrZWx5LCB0aGUgYXV0aG9yIG9mIERldmljZSBUcmVlCiAgcGh5dGVjLHBj bTAzMCAgIC0gd3JpdHRlbiBieSBHcmFudCBMaWtlbHksIHRoZSBhdXRob3Igb2YgRGV2aWNlIFRy ZWUKClBDTSBkZXZpY2VzIHdoaWNoIHJlZ2lzdGVyIGFzIGFjdHVhbCBkZXZpY2VzIChzaG91bGQg YmUgaW4gRFQpOgogIHNhbXN1bmcgIC0gc2Ftc3VuZy1wY20KICBzaCAgICAgICAtIHNpdS1wY20t YXVkaW8KICBvbWFwICAgICAtIG9tYXAtcGNtLWF1ZGlvCiAgcHhhICAgICAgLSBweGEtcGNtLWF1 ZGlvCiAgano0NzQwICAgLSBqejQ3NDAtcGNtLWF1ZGlvCiAga2lya3dvb2QgLSBraXJrd29vZC1w Y20tYXVkaW8KICBlcDkzeHggICAtIGVwOTN4eC1wY20tYXVkaW8KICAuLi4KClRoZSBsYXRlciB3 YXMgYmFzaWNhbGx5IGV2ZXJ5IFBDTSBkZXZpY2UgYmFyIG9uZSBJIHRoaW5rLgoKVGhlIE9wZW4g RmlybXdhcmUgdXNlZCB0byBzdGlwdWxhdGUgdGhhdCBlYWNoIGRldmljZSByZXByZXNlbnRlZCBp bgp0aGUgRGV2aWNlIFRyZWUgdG8gb3duIHJlZ2lzdGVycyBhbmQgdGhlcmVmb3JlIGJlIGFuIGFj dHVhbCBoYXJkd2FyZQpkZXZpY2UsIGJ1dCB0aGF0IGhhcyBzaW5jZSBiZWVuIGxpZnRlZCBhcyBp dCBkaWRuJ3QgbWFrZSBzZW5zZS4KCkkgcHJvcG9zZSB0byByZXByZXNlbnQgdGhlIFBDTSBpbiB0 aGUgRGV2aWNlIFRyZWUgYWdhaW4gYW5kIGhhdmUgaXQKcHJvYmUganVzdCBsaWtlIGFsbCB0aGUg b3RoZXIgUENNIGRldmljZXMgaW4gc291bmQvc29jLgoKSWYgeW91IGdpdmUgbWUgdGhlIG5vZCwg SSdsbCByZXZlcnQgdGhpcyBwYXRjaCwgZW5hYmxlIHRoZSBQQ00gZm9yIERUCmFnYWluIGFuZCBy ZXNlbnQgdGhlIHBhdGNoLXNldCBpbiBmdWxsLgoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1QtRXJp Y3Nzb24gTGFuZGluZyBUZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdh cmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZl bCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9tYWlsbWFu LmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 23 Aug 2012 10:22:17 +0100 Subject: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device In-Reply-To: <006d01cd7f5a$65937840$30ba68c0$@se> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-8-git-send-email-lee.jones@linaro.org> <002801cd7c31$14d3d0c0$3e7b7240$@se> <20120820085111.GJ8450@gmail.com> <006d01cd7f5a$65937840$30ba68c0$@se> Message-ID: <20120823092216.GA27264@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Mark, > > > I'm sorry but this patch is breaking the design of ASoC. > > > The ASoC-platform is the DMA-block (in combination with the > > > MSP-block), and there should be a platform-driver for the DMA/PCM. > > > The > > > platform-driver then has a DAI which is the MSP. The ASoC > > > DAI-link-struct should have one driver for each of these, so the > > > dummy-driver for PCM should be there. > > > > Just thinking about this now. I converted it to the current format at > > the request of Mark. If this isn't the correct method I'm not quite > > sure what is. If you want it to be registered as a device, then it > > needs to go into the Device Tree, but Mark doesn't want it in there > > because it doesn't actually represent hardware. I've just taken a closer look at this with a view to finding the most suitable solution. My conclusion is that although the PCM doesn't contain any registers, or represent hardware it should be a device and therefore be present in the Device Tree. These are my findings: PCM devices already represented in DTs: fsl,mpc5200-pcm - written by Grant Likely, the author of Device Tree phytec,pcm030 - written by Grant Likely, the author of Device Tree PCM devices which register as actual devices (should be in DT): samsung - samsung-pcm sh - siu-pcm-audio omap - omap-pcm-audio pxa - pxa-pcm-audio jz4740 - jz4740-pcm-audio kirkwood - kirkwood-pcm-audio ep93xx - ep93xx-pcm-audio ... The later was basically every PCM device bar one I think. The Open Firmware used to stipulate that each device represented in the Device Tree to own registers and therefore be an actual hardware device, but that has since been lifted as it didn't make sense. I propose to represent the PCM in the Device Tree again and have it probe just like all the other PCM devices in sound/soc. If you give me the nod, I'll revert this patch, enable the PCM for DT again and resent the patch-set in full. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog