From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4qp4-0000YS-7b for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:09:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4qp2-0007zf-TI for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:09:02 -0400 Received: from hall.aurel32.net ([88.191.126.93]:53118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4qp2-0007zY-Ni for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:09:00 -0400 Date: Fri, 24 Aug 2012 12:08:58 +0200 From: Aurelien Jarno Message-ID: <20120824100858.GF1687@hall.aurel32.net> References: <1345736379-16101-1-git-send-email-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH ] lan9118: fix multicast filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , qemu-devel@nongnu.org On Fri, Aug 24, 2012 at 10:47:47AM +0100, Stefan Hajnoczi wrote: > On Thu, Aug 23, 2012 at 4:39 PM, Aurelien Jarno wrote: > > The lan9118 emulation tries to compute the multicast index by calling > > directly the crc32() function from zlib, but fails to get the correct > > result. > > > > Use the common compute_mcast_idx() function instead, which gives the > > correct result. This fixes IPv6 support. > > > > Signed-off-by: Aurelien Jarno > > --- > > hw/lan9118.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > There is another crc32() call in hw/lan9118.c:lan9118_receive(). Can > that be replaced too and then #include can be dropped? > I don't think so, at least not easily. This is a different call (the length is variable), and most emulated NICs have a call to crc32(), but in slightly different ways. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net