All of lore.kernel.org
 help / color / mirror / Atom feed
From: p.d@gmx.de
To: Andrew Cooper <andrew.cooper3@citrix.com>, Ian.Campbell@citrix.com
Cc: xen-devel@lists.xen.org
Subject: Re: Errors in compilation // xl_cmdimpl.c:2733:11 ...
Date: Fri, 24 Aug 2012 23:46:08 +0200	[thread overview]
Message-ID: <20120824214608.46820@gmx.net> (raw)
In-Reply-To: <5037D4C3.4060309@citrix.com>

THX for quickly answer.

With HG I have not so much experience, so sorry for novice question:
should I patching with "hg import" according to the documentation, or there are some differences, because of some errors?

#hg import fix-cmdimpl.patch
Turning to fix cmdimpl.patch
Turning to patch file tools / libxl / to xl_cmdimpl.c
BUST of section # 1 at line 2685
BUST of section # 2 at line 2713
BUST of section # 3 in line 2724
BUST of section # 4 on line 2737
4 of 4 sections are FAILED - save Committee to file tools / libxl / xl_cmdimpl.c.rej
Demolition: Patch failed
(google translated)


#hg import fix-cmdimpl-v2.patch
Abbruch: Ausstehende nicht versionierte Änderungen
Demolition: Outstanding unversioned changes (w. Google translated)

I changed xl_cmdimpl.c according to Your patches by hand and tried compile it. It works.

Best regards.
Panschinski Denis


[cut]

> Sadly, hand being touched iff format == JSON was still not enough to
> satisfy my version of GCC.
> 
> Attached is a far slimmed version which explicitly sets hand to NULL at
> the top, and future-proofs the use of hand in the middle of the domain
> loop.
> 
> -- 
> Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
> T: +44 (0)1223 225 900, http://www.citrix.com
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2012-08-24 21:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24 16:43 Errors in compilation // xl_cmdimpl.c:2733:11 p.d
2012-08-24 18:42 ` Andrew Cooper
2012-08-24 19:12   ` Ian Campbell
2012-08-24 19:23     ` Andrew Cooper
2012-08-24 21:46       ` p.d [this message]
2012-08-28 14:00       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120824214608.46820@gmx.net \
    --to=p.d@gmx.de \
    --cc=Ian.Campbell@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.