From: Jonathan Corbet <corbet@lwn.net>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Pawel Osciak <pawel@osciak.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void
Date: Sat, 25 Aug 2012 11:30:21 -0600 [thread overview]
Message-ID: <20120825113021.690440ba@lwn.net> (raw)
In-Reply-To: <CALF0-+VEGKL6zqFcqkw__qxuy+_3aDa-0u4xD63+Mc4FioM+aw@mail.gmail.com>
On Sat, 25 Aug 2012 13:12:01 -0300
Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> The mentioned BUG_ON() are these:
>
> void vb2_queue_init(struct vb2_queue *q)
> {
> BUG_ON(!q);
> BUG_ON(!q->ops);
> BUG_ON(!q->mem_ops);
> BUG_ON(!q->type);
> BUG_ON(!q->io_modes);
> [...]
>
> Unless I'm overlooking something they look fine to me,
> since vb2_queue should always be prepared by the driver.
http://permalink.gmane.org/gmane.linux.kernel/1347333 is, I believe, the
definitive word on this kind of use of BUG_ON()...
jon
next prev parent reply other threads:[~2012-08-25 17:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 3:08 [PATCH 1/9] s5p: Don't check vb2_queue_init() return value Ezequiel Garcia
2012-08-25 3:08 ` [PATCH 2/9] coda: " Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 3/9] mem2mem-emmaprp: " Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 4/9] mem2mem-deinterlace: " Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 5/9] marvel-cam: " Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 6/9] soc-camera: " Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 7/9] stk1160: Don't check vb2_queue_init() return Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 8/9] mem2mem_testdev: Don't check vb2_queue_init() return value Ezequiel Garcia
2012-08-25 3:09 ` [PATCH 9/9] videobuf2-core: Change vb2_queue_init return type to void Ezequiel Garcia
2012-08-25 15:28 ` Jonathan Corbet
2012-08-25 16:12 ` Ezequiel Garcia
2012-08-25 17:30 ` Jonathan Corbet [this message]
2012-08-26 22:59 ` Ezequiel Garcia
2012-08-28 16:55 ` Jonathan Corbet
2012-08-28 17:23 ` Ezequiel Garcia
2012-09-15 12:48 ` Mauro Carvalho Chehab
2012-09-15 13:05 ` Ezequiel Garcia
[not found] ` <20120915103719.4f038ee0@redhat.com>
[not found] ` <CALF0-+Vrf+t1eN+0LRGP4rBrrbSxrwTgkY1205v=7=5YQxsqWg@mail.gmail.com>
2012-09-15 15:22 ` Ezequiel Garcia
2012-09-15 16:13 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120825113021.690440ba@lwn.net \
--to=corbet@lwn.net \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@redhat.com \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.