Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, Aug 25, 2012 at 12:01:26AM +0100, Peter Maydell wrote:
> On 24 August 2012 19:43, Andreas Färber <afaerber@suse.de> wrote:
> > Depends on what you mean with "disable"? Adding an #error would hurt our
> > arm build just like earlier the ppc build, and I would hope from my last
> > testing that the problems would only affect the AREG0 targets,
> > especially not ARM on ARM (or MIPS on MIPS).
> >
> > Aborting at runtime, only when really unsupported, would seem better.
> >
> > I had taken a look at tcg/arm/ shortly after having fixed ppc (seeing
> > that there was a similar TODO or FIXME) but got distracted by other
> > projects. And your remarks wrt stack sound a bit frightening now. ;)
> > @Peter, have you looked into tcg/arm/ AREG0 support?
> 
> Not yet. Why did we commit something that broke half our TCG
> targets and why don't we just back it out for 1.2 ?
> 

I haven't tried, but for what I can see in the commit log, it was already
broken in 1.1.


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net