From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wi0-f169.google.com ([209.85.212.169]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1T5H70-00054x-VF for linux-mtd@lists.infradead.org; Sat, 25 Aug 2012 14:13:19 +0000 Received: by wibhm2 with SMTP id hm2so2332594wib.0 for ; Sat, 25 Aug 2012 07:13:16 -0700 (PDT) From: Marek Vasut To: dedekind1@gmail.com Subject: Re: [PATCH V4] mtd: m25p80: Make fast read configurable via DT Date: Sat, 25 Aug 2012 16:06:48 +0200 References: <1345729313-10831-1-git-send-email-marex@denx.de> <1345899551.1815.10.camel@kyv> In-Reply-To: <1345899551.1815.10.camel@kyv> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201208251606.48789.marex@denx.de> Cc: robherring2@gmail.com, devicetree-discuss@lists.ozlabs.org, linux-mtd@lists.infradead.org, David Woodhouse , Artem Bityutskiy List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Dear Artem Bityutskiy, > On Thu, 2012-08-23 at 15:41 +0200, Marek Vasut wrote: > > Add DT property "m25p,fast-read" that signalises the particular > > chip supports "fast read" opcode. > > > > Signed-off-by: Marek Vasut > > Cc: Artem Bityutskiy > > Cc: David Woodhouse > > Does not compile if (I think) OF is not enabled. > > drivers/mtd/devices/m25p80.c: In function 'm25p_probe': > drivers/mtd/devices/m25p80.c:920:2: error: implicit declaration of function > 'of_property_read_bool' [-Werror=implicit-function-declaration] cc1: some > warnings being treated as errors > make[4]: *** [drivers/mtd/devices/m25p80.o] Error 1 Argh, of course. Wrapping that part in ifdef CONFIG_OF should do the trick. So much for having CONFIG_OF on all the time. Thanks! Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH V4] mtd: m25p80: Make fast read configurable via DT Date: Sat, 25 Aug 2012 16:06:48 +0200 Message-ID: <201208251606.48789.marex@denx.de> References: <1345729313-10831-1-git-send-email-marex@denx.de> <1345899551.1815.10.camel@kyv> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345899551.1815.10.camel@kyv> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: dedekind1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, David Woodhouse , Artem Bityutskiy List-Id: devicetree@vger.kernel.org Dear Artem Bityutskiy, > On Thu, 2012-08-23 at 15:41 +0200, Marek Vasut wrote: > > Add DT property "m25p,fast-read" that signalises the particular > > chip supports "fast read" opcode. > > > > Signed-off-by: Marek Vasut > > Cc: Artem Bityutskiy > > Cc: David Woodhouse > > Does not compile if (I think) OF is not enabled. > > drivers/mtd/devices/m25p80.c: In function 'm25p_probe': > drivers/mtd/devices/m25p80.c:920:2: error: implicit declaration of function > 'of_property_read_bool' [-Werror=implicit-function-declaration] cc1: some > warnings being treated as errors > make[4]: *** [drivers/mtd/devices/m25p80.o] Error 1 Argh, of course. Wrapping that part in ifdef CONFIG_OF should do the trick. So much for having CONFIG_OF on all the time. Thanks! Best regards, Marek Vasut