From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] luajit: bug fix - prevent target CFLAGS from being used in host tool compile.
Date: Sun, 26 Aug 2012 11:20:16 +0200 [thread overview]
Message-ID: <20120826112016.13c9caae@skate> (raw)
In-Reply-To: <1344993930-2730-1-git-send-email-danomimanchego123@gmail.com>
Le Tue, 14 Aug 2012 21:25:30 -0400,
Danomi Manchego <danomimanchego123@gmail.com> a ?crit :
> The luajit amalgamation compile starts with building a host tool, and then
> uses it to build itself. ?However, when CFLAGS is specified, as opposed to
> TARGET_CFLAGS, then it is used for both HOST and TARGET builds. ?So if you
> add something target specific into 'Target Optimizations' (for example,
> '-mfpu=neon -mfloat-abi=softfp' for ARM Cortex-A8), then it gets into the
> host tool compile, which then fails (because my build machine is not an
> ARM Cortext-A8). ?This can be fixed by using TARGET_CFLAGS and
> TARGET_LDFLAGS, instead of CFLAGS and LDFLAGS, respectively.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
Applied, thanks. It fixes build issues like
http://autobuild.buildroot.net/results/022b73a989734d800225c91f419f18f4fc31c264/build-end.log.
Danomi, could you share what is your Buildroot configuration that uses
-mfpu=neon -mfloat-abi=softfp ? I might be interested in adding such a
configuration to the autobuilders.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-08-26 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 1:25 [Buildroot] [PATCH] luajit: bug fix - prevent target CFLAGS from being used in host tool compile Danomi Manchego
2012-08-23 15:09 ` [Buildroot] [UNSURE] " François Perrad
2012-08-26 9:20 ` Thomas Petazzoni [this message]
2012-08-26 16:14 ` [Buildroot] " Danomi Manchego
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120826112016.13c9caae@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.