All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [vfs:master 30/32] fs/proc/fd.c:87:55: sparse: incorrect type in initializer (different base typ
Date: Sun, 26 Aug 2012 20:20:49 +0000	[thread overview]
Message-ID: <20120826202049.GA23464@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120826191257.GC9107@localhost>

On Sun, Aug 26, 2012 at 11:52:36PM +0400, Cyrill Gorcunov wrote:
> -				unsigned f_mode = file->f_mode;
> +				unsigned int f_mode = file->f_mode;

This changes nothing; unsigned and unsigned int are exactly the same.
fmode_t isn't, from sparse POV, and that's what you want to use here.

  parent reply	other threads:[~2012-08-26 20:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-26 19:12 [vfs:master 30/32] fs/proc/fd.c:87:55: sparse: incorrect type in initializer (different base types) Fengguang Wu
2012-08-26 19:26 ` [vfs:master 30/32] fs/proc/fd.c:87:55: sparse: incorrect type in initializer (different base typ Cyrill Gorcunov
2012-08-26 19:52 ` Cyrill Gorcunov
2012-08-26 20:20 ` Al Viro [this message]
2012-08-26 20:40 ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120826202049.GA23464@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.