All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Paul Mackerras <paulus@samba.org>,
	Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp,
	avi@redhat.com, xiaoguangrong@linux.vnet.ibm.com
Subject: Re: [PATCH v2] kvm/book3s: fix build error caused by gfn_to_hva_memslot()
Date: Mon, 27 Aug 2012 16:52:55 -0300	[thread overview]
Message-ID: <20120827195255.GA30661@amt.cnet> (raw)
In-Reply-To: <20120824090314.GB7051@bloggs.ozlabs.ibm.com>

On Fri, Aug 24, 2012 at 07:03:14PM +1000, Paul Mackerras wrote:
> On Fri, Aug 24, 2012 at 04:50:28PM +0800, Gavin Shan wrote:
> > The build error was caused by that builtin functions are calling
> > the functions implemented in modules. That was introduced by the
> > following commit.
> > 
> > commit 4d8b81abc47b83a1939e59df2fdb0e98dfe0eedd
> > 
> > The patch fixes the build error by moving function __gfn_to_hva_memslot()
> > from kvm_main.c to kvm_host.h and making that "inline" so that the
> > builtin function (kvmppc_h_enter) can use that.
> > 
> > Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
> 
> Acked-by: Paul Mackerras <paulus@samba.org>
> 
> By the way, when you give a commit ID it's a good idea to give the
> headline of the commit as well, something like this:
> 
> This error was introduced by commit 4d8b81abc4 ("KVM: introduce
> readonly memslot").
> 
> Paul.

Applied, thanks (with suggested changelog modification).

      reply	other threads:[~2012-08-27 20:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-24  8:50 [PATCH v2] kvm/book3s: fix build error caused by gfn_to_hva_memslot() Gavin Shan
2012-08-24  9:03 ` Paul Mackerras
2012-08-27 19:52   ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120827195255.GA30661@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=shangw@linux.vnet.ibm.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    --cc=yoshikawa.takuya@oss.ntt.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.