From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: balbi@ti.com, ralf@linux-mips.org, sebastian@breakpoint.cc,
stern@rowland.harvard.edu, linux-mips@linux-mips.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH V4] usb: gadget: bcm63xx UDC driver
Date: Mon, 27 Aug 2012 22:46:13 +0200 [thread overview]
Message-ID: <20120827204613.GC6045@breakpoint.cc> (raw)
In-Reply-To: <2e70dcfde41aee0d733449013ac80ace@localhost>
On Sat, Aug 25, 2012 at 12:38:52PM -0700, Kevin Cernekee wrote:
> Driver for the "USB20D" / "USBD" block on BCM6328, BCM6368, BCM6816,
> BCM6362, BCM3383, and others.
I don't see anything worth to object.
Acked-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
One little question: Felipe suggested to replace the workqueue by a threaded
interrupt. You schedule the workqueue in interrupt context and once in ep0
enqueue. The enqueue should be fine by executing one round and waiting for the
interrupt. Any reason why you suggested against it?
Sebastian
next prev parent reply other threads:[~2012-08-27 20:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 19:38 [PATCH V4] usb: gadget: bcm63xx UDC driver Kevin Cernekee
2012-08-27 20:46 ` Sebastian Andrzej Siewior [this message]
2012-08-27 21:35 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120827204613.GC6045@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=balbi@ti.com \
--cc=cernekee@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.