All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: <mingo@elte.hu>, <a.p.zijlstra@chello.nl>, <namhyung@kernel.org>,
	<dsahern@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH  v2 1/3] perf tools: Fix a compiling error in trace-event-perl.c for 32 bits machine
Date: Tue, 28 Aug 2012 10:17:30 +0800	[thread overview]
Message-ID: <20120828101730.6b2fd97e@feng-i7> (raw)
In-Reply-To: <20120827153355.GA17634@infradead.org>

>From 8e2fe258906fc83869be10a1b4a40ef9acc4a2a6 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Mon, 27 Aug 2012 14:01:33 +0800
Subject: [PATCH 1/3] perf tools: Fix a compiling error in trace-event-perl.c for 32 bits machine

On my x86_32 mahcine, there is a compile error:

	CC util/scripting-engines/trace-event-perl.o
	cc1: warnings being treated as errors
	util/scripting-engines/trace-event-perl.c: In function ‘perl_process_tracepoint’:
	util/scripting-engines/trace-event-perl.c:285: error: format ‘%d’ expects type ‘int’, but argument 2 has type ‘__u64’
	make: *** [util/scripting-engines/trace-event-perl.o] Error 1

Fix it by using the "%PRIu64" for __u64.

v2: use PRIu64 as suggested by Arnaldo.

Signed-off-by: Feng Tang <feng.tang@intel.com>
---
 .../perf/util/scripting-engines/trace-event-perl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/scripting-engines/trace-event-perl.c b/tools/perf/util/scripting-engines/trace-event-perl.c
index d280010..09db03f 100644
--- a/tools/perf/util/scripting-engines/trace-event-perl.c
+++ b/tools/perf/util/scripting-engines/trace-event-perl.c
@@ -282,7 +282,7 @@ static void perl_process_tracepoint(union perf_event *perf_event __unused,
 
 	event = find_cache_event(evsel);
 	if (!event)
-		die("ug! no event found for type %d", evsel->attr.config);
+		die("ug! no event found for type %" PRIu64, evsel->attr.config);
 
 	pid = raw_field_value(event, "common_pid", data);
 
-- 
1.7.1

  reply	other threads:[~2012-08-28  2:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-27  7:38 [PATCH 0/3] perf tools: Fixes for some compile errors Feng Tang
2012-08-27  7:38 ` [PATCH 1/3] perf tools: Fix a compiling error in trace-event-perl.c for 32 bits machine Feng Tang
2012-08-27 15:33   ` Arnaldo Carvalho de Melo
2012-08-28  2:17     ` Feng Tang [this message]
2012-09-27  4:22       ` [tip:perf/core] " tip-bot for Feng Tang
2012-08-27  7:38 ` [PATCH 2/3] Perf tools: Fix a compiling error in util/map.c Feng Tang
2012-09-27  4:23   ` [tip:perf/core] perf " tip-bot for Feng Tang
2012-08-27  7:38 ` [PATCH 3/3] perf tools: Fix a misuse of for_each_set_bit() in session.c Feng Tang
2012-08-27  7:59   ` Namhyung Kim
2012-08-27  8:18     ` Feng Tang
2012-12-18 17:39       ` Akemi Yagi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828101730.6b2fd97e@feng-i7 \
    --to=feng.tang@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.