From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2 02/14] MFD: twl4030-audio: Convert to use devm_kzalloc Date: Tue, 28 Aug 2012 09:48:26 -0700 Message-ID: <20120828164825.GA4534@opensource.wolfsonmicro.com> References: <1344954162-7985-1-git-send-email-peter.ujfalusi@ti.com> <1344954162-7985-3-git-send-email-peter.ujfalusi@ti.com> <1346147410.2182.96.camel@sokoban> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id F1FD1266106 for ; Tue, 28 Aug 2012 18:48:30 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1346147410.2182.96.camel@sokoban> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Tero Kristo Cc: Grant Likely , alsa-devel@alsa-project.org, Benoit Cousson , Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , Peter Ujfalusi , linux-omap@vger.kernel.org, Liam Girdwood , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Tue, Aug 28, 2012 at 12:50:10PM +0300, Tero Kristo wrote: > On Tue, 2012-08-14 at 17:22 +0300, Peter Ujfalusi wrote: > > Signed-off-by: Peter Ujfalusi > I think this one could use a short commit message, also about why > kfree():s are dropped (handled internally by devm_* etc.) Honestly I think people should be able to figure this out, it's not like it's an obscure API nobody ever used before. From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Tue, 28 Aug 2012 09:48:26 -0700 Subject: [PATCH v2 02/14] MFD: twl4030-audio: Convert to use devm_kzalloc In-Reply-To: <1346147410.2182.96.camel@sokoban> References: <1344954162-7985-1-git-send-email-peter.ujfalusi@ti.com> <1344954162-7985-3-git-send-email-peter.ujfalusi@ti.com> <1346147410.2182.96.camel@sokoban> Message-ID: <20120828164825.GA4534@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 28, 2012 at 12:50:10PM +0300, Tero Kristo wrote: > On Tue, 2012-08-14 at 17:22 +0300, Peter Ujfalusi wrote: > > Signed-off-by: Peter Ujfalusi > I think this one could use a short commit message, also about why > kfree():s are dropped (handled internally by devm_* etc.) Honestly I think people should be able to figure this out, it's not like it's an obscure API nobody ever used before. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753259Ab2H1Qsc (ORCPT ); Tue, 28 Aug 2012 12:48:32 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:44458 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982Ab2H1Qsb (ORCPT ); Tue, 28 Aug 2012 12:48:31 -0400 Date: Tue, 28 Aug 2012 09:48:26 -0700 From: Mark Brown To: Tero Kristo Cc: Peter Ujfalusi , Liam Girdwood , Tony Lindgren , Grant Likely , Rob Herring , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree-discuss@lists.ozlabs.org, Benoit Cousson , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/14] MFD: twl4030-audio: Convert to use devm_kzalloc Message-ID: <20120828164825.GA4534@opensource.wolfsonmicro.com> References: <1344954162-7985-1-git-send-email-peter.ujfalusi@ti.com> <1344954162-7985-3-git-send-email-peter.ujfalusi@ti.com> <1346147410.2182.96.camel@sokoban> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1346147410.2182.96.camel@sokoban> X-Cookie: Today is what happened to yesterday. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 28, 2012 at 12:50:10PM +0300, Tero Kristo wrote: > On Tue, 2012-08-14 at 17:22 +0300, Peter Ujfalusi wrote: > > Signed-off-by: Peter Ujfalusi > I think this one could use a short commit message, also about why > kfree():s are dropped (handled internally by devm_* etc.) Honestly I think people should be able to figure this out, it's not like it's an obscure API nobody ever used before.