From: Johan Hedberg <johan.hedberg@gmail.com>
To: Garbat Rafal <rafal.garbat@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
Santiago Carot-Nemesio <sancane@gmail.com>
Subject: Re: [PATCH v2 01/13] Heart Rate Profile API
Date: Tue, 28 Aug 2012 09:56:50 -0700 [thread overview]
Message-ID: <20120828165650.GA3165@x220.sheraton.com> (raw)
In-Reply-To: <503CE72D.2030501@tieto.com>
Hi Rafal,
On Tue, Aug 28, 2012, Garbat Rafal wrote:
> >>I'm wondering if it wouldn't make more sense to have these
> >>RegisterWatcher APIs (thermometer, heart rate, others?) per-adapter
> >>instead of per-device. That would be much friendlier to applications in
> >>that they wouldn't need to separately search for paired/configured
> >>devices supporting a specific service. Moving this to be per-adapter
> >>would also mean that the first parameter of the Watcher methods would be
> >>the object path of which device is in question.
> >So any comments on this? I'd like to get this moving forward and finally
> >merged upstream.
>
> Sorry for a late reply.
> I guess that moving RegisterWatcher methods to the adapter iface
> sounds reasonable, but we need to think how to do it i.e. to
> properly handle devices that support several profiles based on
> registering watchers (do we want to register watcher for all the
> profiles or have a parameter for Watcher methods to specify the
> target), etc.
> Correct me if I'm wrong or missing something.
> I'd suggest merging heartrate as this profile is quite similar to
> the thermometer and it works (and no one have any objections to the
> code) and re-factor this later on.
> Unfortunately I'll be off for the next three weeks, but I can get
> back to this when I'm back.
Since it's not just a refactoring but an API change/break I'd rather get
this right from the start. The thermometer API should also be updated to
be per-adapter for our next release (BlueZ 5).
Johan
next prev parent reply other threads:[~2012-08-28 16:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 15:08 [PATCH v2 00/13] Add Heart Rate Service Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 01/13] Heart Rate Profile API Rafal Garbat
2012-08-14 9:56 ` Johan Hedberg
2012-08-28 15:20 ` Johan Hedberg
2012-08-28 15:43 ` Garbat Rafal
2012-08-28 16:56 ` Johan Hedberg [this message]
2012-08-28 17:55 ` Anderson Lizardo
2012-08-28 18:10 ` Johan Hedberg
2012-08-28 18:23 ` Anderson Lizardo
2012-08-28 19:21 ` Anderson Lizardo
2012-08-29 9:42 ` Garbat Rafal
2012-08-29 17:54 ` Anderson Lizardo
2012-08-29 17:57 ` Johan Hedberg
2012-08-13 15:08 ` [PATCH v2 02/13] heartrate: Add Heart Rate Service GATT client skeleton Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 03/13] heartrate: Add conn logic and attio callbacks Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 04/13] heartrate: Discover Characteristic Descriptors Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 05/13] heartrate: Process Heart Rate Descriptors Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 06/13] heartrate: Add DBus connection logic Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 07/13] heartrate: Process Heart Rate Characteristics Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 08/13] heartrate: Add notification support Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 09/13] heartrate: Process measurements Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 10/13] heartrate: Add support for Control Point Reset Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 11/13] heartrate: Add GetProperties method handle Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 12/13] heartrate: Add org.bluez.HeartRateWatcher iface to default policy Rafal Garbat
2012-08-13 15:08 ` [PATCH v2 13/13] heartrate: Add Heart Rate test script Rafal Garbat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828165650.GA3165@x220.sheraton.com \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=rafal.garbat@tieto.com \
--cc=sancane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.