From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types Date: Tue, 28 Aug 2012 20:22:58 +0300 Message-ID: <20120828172258.GC3661@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , avi@redhat.com, mtosatti@redhat.com, gleb@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, Jan Kiszka To: Blue Swirl Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42607 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041Ab2H1RVn (ORCPT ); Tue, 28 Aug 2012 13:21:43 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote: > > +static bool _kvm_pv_eoi_disabled; > > NACK. I find your lack of compliance disturbing. Compliance with what? Could you please add some motivation for the NACK? -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PU7-0000Tt-7P for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:21:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T6PTz-00076o-KJ for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:21:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T6PTz-00076b-Bz for qemu-devel@nongnu.org; Tue, 28 Aug 2012 13:21:43 -0400 Date: Tue, 28 Aug 2012 20:22:58 +0300 From: "Michael S. Tsirkin" Message-ID: <20120828172258.GC3661@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: gleb@redhat.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, Jan Kiszka , avi@redhat.com, Anthony Liguori On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote: > > +static bool _kvm_pv_eoi_disabled; > > NACK. I find your lack of compliance disturbing. Compliance with what? Could you please add some motivation for the NACK? -- MST