From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions
Date: Tue, 28 Aug 2012 20:32:52 +0300 [thread overview]
Message-ID: <20120828173251.GE3661@redhat.com> (raw)
In-Reply-To: <CAFEAcA8kD5ifL8QJE3d-6mBJ7_kJ7f_eHaoWY0ofL6JmfTDmCg@mail.gmail.com>
On Tue, Aug 28, 2012 at 06:23:38PM +0100, Peter Maydell wrote:
> On 28 August 2012 18:18, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote:
> >> C99 7.1.3
> >> reserves underscore capital and double underscore prefixes.
> >
> > This is taking it out of context - reserved means different
> > things in different parts of the spec.
> >
> > As far as I can see, 7.1.3 talks about what is permissible in headers:
> > naturally when a libc implementation adds stuff in a header it would
> > want to avoid breaking applications including this header. But
> > it does not talk about what is permissible in a legal program - to avoid
> > conflicts, you just need to use variables with reasonable names like
> > kvmXXX qemuXXX or virtioXXX.
>
> 7.1.3 para 2 says "If the program declares or defines an identifier
> in a context in which it is reserved [...] the behavior is undefined."
> The rationale for 7.1.3 says that the underscore-cap and double
> underscore identifiers are "reserved for the implementor" and that
> "part of the name space of internal identifiers beginning with
> underscore is available to the user" which implies that the rest
> of that namespace is *not* available to the user.
>
> I think that's fairly clear that we can't use these identifiers
> without entering the realm of undefined behavior.
>
I'll have to re-read that, I missed it.
What about _t in POSIX? That seems fairly safe if name is long and qemu
specific enough.
--
MST
next prev parent reply other threads:[~2012-08-28 17:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 16:01 [Qemu-devel] [PATCH] HACKING: remove bogus restrictions Michael S. Tsirkin
2012-08-28 16:07 ` Michael S. Tsirkin
2012-08-28 16:24 ` Peter Maydell
2012-08-28 17:18 ` Michael S. Tsirkin
2012-08-28 17:23 ` Peter Maydell
2012-08-28 17:32 ` Michael S. Tsirkin [this message]
2012-08-28 17:46 ` Peter Maydell
2012-08-28 18:00 ` Michael S. Tsirkin
2012-08-28 17:27 ` malc
2012-08-28 17:13 ` Blue Swirl
2012-08-28 17:21 ` Michael S. Tsirkin
2012-08-28 17:25 ` Blue Swirl
2012-08-28 17:27 ` Peter Maydell
2012-08-28 17:33 ` malc
2012-08-28 17:35 ` Michael S. Tsirkin
2012-08-28 17:34 ` Michael S. Tsirkin
2012-08-28 17:33 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828173251.GE3661@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.