From: Marcelo Tosatti <mtosatti@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>,
Paul Mackerras <paulus@samba.org>, Avi Kivity <avi@redhat.com>,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
kvm@vger.kernel.org
Subject: Re: [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific
Date: Tue, 28 Aug 2012 17:41:56 -0300 [thread overview]
Message-ID: <20120828204156.GA19425@amt.cnet> (raw)
In-Reply-To: <20120828093024.837e0147.yoshikawa.takuya@oss.ntt.co.jp>
On Tue, Aug 28, 2012 at 09:30:24AM +0900, Takuya Yoshikawa wrote:
> On Mon, 27 Aug 2012 16:06:01 -0300
> Marcelo Tosatti <mtosatti@redhat.com> wrote:
>
> > > Any explanation why (old.base_gfn != new.base_gfn) case can be
> > > omitted?
> >
> > (old.base_gfn != new.base_gfn) check covers the cases
> >
> > 1. old.base_gfn = 0, new.base_gfn = !0 (slot creation)
> >
> > and
> >
> > x != 0, y != 0, x != y.
> > 2. old.base_gfn = x, new.base_gfn = y (gpa base change)
> >
> > Patch 2 covers case 2, so its only necessary to cover case
> > 1 here.
> >
> > Makes sense?
>
> Yes.
>
> But didn't you change the flush in the if block modified by patch 2
> to kvm_arch_flush_shadow_memslot()?
>
> Although current implementation flushes everything, this may trigger
> problem when we change it.
>
> Takuya
Yay, thanks.
next prev parent reply other threads:[~2012-08-28 20:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 18:54 [patch 0/3] kvm: split kvm_arch_flush_shadow and move mmio spte invalidation to x86 Marcelo Tosatti
2012-08-24 18:54 ` [patch 1/3] KVM: split kvm_arch_flush_shadow Marcelo Tosatti
2012-08-24 18:54 ` [patch 2/3] KVM: perform an invalid memslot step for gpa base change Marcelo Tosatti
2012-08-24 18:54 ` [patch 3/3] KVM: move postcommit flush to x86, as mmio sptes are x86 specific Marcelo Tosatti
2012-08-27 8:04 ` Xiao Guangrong
2012-08-28 20:45 ` Marcelo Tosatti
2012-08-27 14:41 ` Takuya Yoshikawa
2012-08-27 19:06 ` Marcelo Tosatti
2012-08-28 0:30 ` Takuya Yoshikawa
2012-08-28 20:41 ` Marcelo Tosatti [this message]
2012-08-28 20:43 ` [patch 3/3 V2] " Marcelo Tosatti
2012-08-25 12:37 ` [patch 0/3] kvm: split kvm_arch_flush_shadow and move mmio spte invalidation to x86 Paul Mackerras
2012-09-06 13:37 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120828204156.GA19425@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=paulus@samba.org \
--cc=takuya.yoshikawa@gmail.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.