From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params()
Date: Tue, 28 Aug 2012 21:36:28 +0200 [thread overview]
Message-ID: <201208282136.28538.marex@denx.de> (raw)
In-Reply-To: <1346182146-1154-1-git-send-email-fabio.estevam@freescale.com>
Dear Fabio Estevam,
> Recent conversion from mx28_adjust_memory_params to
> mxs_adjust_memory_params missed to update mx28evk, which caused the board
> not to boot.
Oh of course ... that's an obvious flub. I'm very unhappy about the conversion
causing such trouble! Please be more careful next time.
> Apply the conversion so that the board can boot again.
Yes,
Acked-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> board/freescale/mx28evk/iomux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx28evk/iomux.c
> b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
> --- a/board/freescale/mx28evk/iomux.c
> +++ b/board/freescale/mx28evk/iomux.c
> @@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
> #define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
> ADDR_PINS << 8 | APREBIT)
>
> -void mx28_adjust_memory_params(uint32_t *dram_vals)
> +void mxs_adjust_memory_params(uint32_t *dram_vals)
> {
> dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-28 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 19:29 [U-Boot] [PATCH] mx28evk: Convert to mxs_adjust_memory_params() Fabio Estevam
2012-08-28 19:36 ` Marek Vasut [this message]
2012-08-28 19:39 ` Marek Vasut
2012-08-28 21:49 ` Otavio Salvador
2012-09-03 16:47 ` Fabio Estevam
2012-09-03 17:21 ` Stefano Babic
2012-09-04 10:04 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208282136.28538.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.