From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: -next queue and EDID stuff Date: Wed, 29 Aug 2012 09:56:16 +0200 Message-ID: <20120829075616.GA5278@phenom.ffwll.local> References: <503BD762.6070204@redhat.com> <503D553C.9000503@gmail.com> <503D5EB9.2040405@redhat.com> <503D9810.60104@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f49.google.com (mail-bk0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BD839F601 for ; Wed, 29 Aug 2012 00:55:55 -0700 (PDT) Received: by bkcji2 with SMTP id ji2so108405bkc.36 for ; Wed, 29 Aug 2012 00:55:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <503D9810.60104@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Ian Pilcher Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Aug 28, 2012 at 11:18:24PM -0500, Ian Pilcher wrote: > On 08/28/2012 07:13 PM, Adam Jackson wrote: > > On 8/28/12 7:33 PM, Ian Pilcher wrote: > >> Actually, I believe that the error is probably in the Intel driver. As > >> I understand it, it shouldn't be sending audio InfoFrames to a non-HDMI > >> display. > > > > If that's the case then I'd still say "we're doing something else wrong > > here". Quirks - at least at the core drm level - are not for working > > around broken drivers, they're for working around broken displays. > > And I'd agree. > > (Although I suppose one *could* argue that the display is broken in 2 > ways -- it reports audio capabilities that aren't really there, and it > gets confused by any InfoFrames -- AVI or audio.) > > I don't have the knowledge or time to fix the Intel driver, but I've > always planned to at least bugzilla the issue. I can't reasonably do > so, however, until the user-defined quirks infrastructure is in place, > so that the behavior can be demonstrated. > > If you prefer to leave the display broken with Intel GPUs, you can > always just remove the EDID_QUIRK_NO_AUDIO flag: Wrt intel infoframes issues: Have you retested on latest 3.6-rc kernels? We've fixed quite a few bugs for our infoframe support recently ... -Daniel > > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -160,6 +160,10 @@ union edid_quirk > edid_quirk_list[EDID_QUIRK_LIST_SIZE] = { > { { { { EDID_MFG_ID('V', 'S', 'C'), cpu_to_le16(5020) } }, > EDID_QUIRK_FORCE_REDUCED_BLANKING } }, > > + /* LG L246WP */ > + { { { { EDID_MFG_ID('G', 'S', 'M'), cpu_to_le16(0x563f) } }, > + EDID_QUIRK_DISABLE_INFOFRAMES } }, > + > /* > * When adding built-in quirks, please adjust EDID_QUIRK_LIST_SIZE to > * provide some room for user-supplied quirks. > > -- > ======================================================================== > Ian Pilcher arequipeno@gmail.com > "If you're going to shift my paradigm ... at least buy me dinner first." > ======================================================================== > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48