From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Laxman Dewangan <ldewangan@nvidia.com>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Cc: vinod.koul@intel.com, djbw@fb.com, swarren@wwwdotorg.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH RESEND] dma: tegra: add const to of_device_id.data's structure
Date: Wed, 29 Aug 2012 10:49:11 +0200 [thread overview]
Message-ID: <20120829084911.GE28643@pengutronix.de> (raw)
In-Reply-To: <1346217447-19730-1-git-send-email-ldewangan@nvidia.com>
Hello,
On Wed, Aug 29, 2012 at 10:47:27AM +0530, Laxman Dewangan wrote:
> The member "data" of structure of_device_id is changed to const
> pointer. Hence initializing this with const type data.
> This will fix the compilation warning like
> drivers/dma/tegra20-apb-dma.c:1217:9: warning: assignment discards 'const' qualifier from
> pointer target type [enabled by default]
>
> This warning came after the change
> ---------
> commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> of: add const to struct *of_device_id.data
> ---------
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> Acked-by: Vinod Koul <vinod.koul@linux.intel.com>
I took the patch into my series now and split it in two to prevent
warnings in the middle of the series. I assumed the two acks for both
patches and send them in a moment in reply to this mail.
You can find the updated series
git://git.pengutronix.de/git/ukl/linux.git ofdeviceiddata
Arnd or Olof, can you please update the corresponding branch arm-soc
from there?
Best regards and thanks
Uwe
next prev parent reply other threads:[~2012-08-29 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 5:17 [PATCH RESEND] dma: tegra: add const to of_device_id.data's structure Laxman Dewangan
2012-08-29 5:17 ` Laxman Dewangan
2012-08-29 8:49 ` Uwe Kleine-König [this message]
2012-08-29 8:51 ` [PATCH 1/2] dma: tegra: make tegra_dma.chip_data a pointer to const data Uwe Kleine-König
[not found] ` <1346230295-15898-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-08-29 8:51 ` [PATCH 2/2] dma: tegra: make data used as *of_device_id.data const Uwe Kleine-König
2012-08-29 8:51 ` Uwe Kleine-König
2012-09-10 18:21 ` [PATCH 1/2] dma: tegra: make tegra_dma.chip_data a pointer to const data Stephen Warren
2012-09-10 18:21 ` Stephen Warren
2012-09-11 6:58 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120829084911.GE28643@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=djbw@fb.com \
--cc=kernel@pengutronix.de \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.