From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH V6] drm: edid: add support for E-DDC
Date: Thu, 30 Aug 2012 13:58:02 +0300
Message-ID: <20120830105802.GA6906@intel.com>
References: <1346310246-21412-1-git-send-email-s.shirish@samsung.com>
	<1346310246-21412-2-git-send-email-s.shirish@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id C40A79E904
	for <dri-devel@lists.freedesktop.org>;
	Thu, 30 Aug 2012 03:58:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1346310246-21412-2-git-send-email-s.shirish@samsung.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Shirish S <s.shirish@samsung.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, Aug 30, 2012 at 12:34:06PM +0530, Shirish S wrote:
> @@ -276,15 +283,21 @@ drm_do_probe_ddc_edid(struct i2c_adapter *adapter, =
unsigned char *buf,
>  				.buf	=3D buf,
>  			}
>  		};
> -		ret =3D i2c_transfer(adapter, msgs, 2);
> +
> +	/*
> +	 * Avoid sending the segment addr to not upset non-compliant ddc
> +	 * monitors.
> +	 */

Indentation is still wrong. Or is it gettimg mangled by some email server?

> +		ret =3D i2c_transfer(adapter, &msgs[3 - xfers], xfers);
> +
>  		if (ret =3D=3D -ENXIO) {
>  			DRM_DEBUG_KMS("drm: skipping non-existent adapter %s\n",
>  					adapter->name);
>  			break;
>  		}
> -	} while (ret !=3D 2 && --retries);
> +	} while (ret !=3D xfers && --retries);
>  =

> -	return ret =3D=3D 2 ? 0 : -1;
> +	return ret =3D=3D xfers ? 0 : -1;
>  }
>  =

>  static bool drm_edid_is_zero(u8 *in_edid, int length)

-- =

Ville Syrj=E4l=E4
Intel OTC