From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 04/22] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Date: Thu, 30 Aug 2012 14:18:08 +0100 Message-ID: <20120830131807.GI14145@gmail.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-5-git-send-email-lee.jones@linaro.org> <20120820115914.GP8450@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id C662C265D6B for ; Thu, 30 Aug 2012 15:18:12 +0200 (CEST) Received: by eeke50 with SMTP id e50so618506eek.38 for ; Thu, 30 Aug 2012 06:18:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Linus Walleij Cc: Ola LILJA2 , alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, Patrice CHOTARD , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gTW9uLCBBdWcgMjcsIDIwMTIgYXQgMDQ6MDk6NDZQTSAtMDcwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBPbiBNb24sIEF1ZyAyMCwgMjAxMiBhdCA0OjU5IEFNLCBMZWUgSm9uZXMgPGxlZS5q b25lc0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+IE9uIFR1ZSwgQXVnIDE0LCAyMDEyIGF0IDEwOjUx OjAyQU0gKzAyMDAsIExpbnVzIFdhbGxlaWogd3JvdGU6Cj4gCj4gPj4gQnV0IHdhaXQuIFRoZXNl IGFyZSBqdXN0IGxvY2FsIHN0YXRpY3MuIFN1cmVsdHkgeW91IGNhbiBwdXQgdGhlc2UgaW50bwo+ ID4+IHN0cnVjdCB1eDUwMF9tc3AgaW5zdGVhZD8gSGVyZSBpdCBsb29rcyBsaWtlIHRoZXNlIHdp bGwgYmUgdXNlZCBmb3IKPiA+PiBhbGwgcG9ydHMsIHNvIE1TUDIgd2lsbCBlbmFibGUgdGhlIHBp bnMgcmVxdWVzdGVkIGJ5IE1TUDEgZXRjCj4gPj4gY29tcGxldGVseSBicm9rZW4uIFNvIHB1dCBp dCBpbnRvIHRoZSBzdHJ1Y3QgdXg1MDBfbXNwIHN0YXRlCj4gPj4gY29udGFpbmVyIGZyb20gdXg1 MDBfbXNwX2kycy5oIHdoZXJlIGl0IGJlbG9uZ3MuCj4gPj4KPiA+PiBSZWZlciB0byBkcml2ZXJz L3R0eS9zZXJpYWwvYW1iYS1wbDAxMS5jIHdoZW4gaW4gdHJvdWJsZS4gVGhpcwo+ID4+IG9uZSBp cyBhIGdvb2QgcGluY3RybCBleGFtcGxlLgo+ID4KPiA+IEhvdyBkbyB5b3Ugc2VlIHRoZSBNU1Ax IGFuZCBNU1AzIHVzYWdlIHByb3RlY3Rpb24gd29ya2luZyBpZiBJIGhpZGUgaXQKPiA+IGFsbCBh d2F5IGluIE1TUCBzcGVjaWZpYyBzdHJ1Y3RzPwo+IAo+IFVzYWdlIHByb3RlY3Rpb24/IFNvcnJ5 IG5vdCBmb2xsb3dpbmcuIFBsZWFzZSBlbGFib3JhdGUuLi4KCkRvbid0IHdvcnJ5IGFib3V0IGl0 LCBJIHRoaW5rIEkgc29ydGVkIGl0LgoKUGxlYXNlIHNlZSB0aGUgbGFzdGVzdCB2ZXJzaW9uIG9m IHRoZSBwYXRjaCAoc2VudCBvbiAyNHRoIEF1ZykuCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1F cmljc3NvbiBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0 d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxv ZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRl dmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxt YW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 30 Aug 2012 14:18:08 +0100 Subject: [PATCH 04/22] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver In-Reply-To: References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-5-git-send-email-lee.jones@linaro.org> <20120820115914.GP8450@gmail.com> Message-ID: <20120830131807.GI14145@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Aug 27, 2012 at 04:09:46PM -0700, Linus Walleij wrote: > On Mon, Aug 20, 2012 at 4:59 AM, Lee Jones wrote: > > On Tue, Aug 14, 2012 at 10:51:02AM +0200, Linus Walleij wrote: > > >> But wait. These are just local statics. Surelty you can put these into > >> struct ux500_msp instead? Here it looks like these will be used for > >> all ports, so MSP2 will enable the pins requested by MSP1 etc > >> completely broken. So put it into the struct ux500_msp state > >> container from ux500_msp_i2s.h where it belongs. > >> > >> Refer to drivers/tty/serial/amba-pl011.c when in trouble. This > >> one is a good pinctrl example. > > > > How do you see the MSP1 and MSP3 usage protection working if I hide it > > all away in MSP specific structs? > > Usage protection? Sorry not following. Please elaborate... Don't worry about it, I think I sorted it. Please see the lastest version of the patch (sent on 24th Aug). -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220Ab2H3NSP (ORCPT ); Thu, 30 Aug 2012 09:18:15 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:63341 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779Ab2H3NSN (ORCPT ); Thu, 30 Aug 2012 09:18:13 -0400 Date: Thu, 30 Aug 2012 14:18:08 +0100 From: Lee Jones To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, STEricsson_nomadik_linux@list.st.com, Patrice CHOTARD , Ola LILJA2 Subject: Re: [PATCH 04/22] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Message-ID: <20120830131807.GI14145@gmail.com> References: <1344527268-5964-1-git-send-email-lee.jones@linaro.org> <1344527268-5964-5-git-send-email-lee.jones@linaro.org> <20120820115914.GP8450@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2012 at 04:09:46PM -0700, Linus Walleij wrote: > On Mon, Aug 20, 2012 at 4:59 AM, Lee Jones wrote: > > On Tue, Aug 14, 2012 at 10:51:02AM +0200, Linus Walleij wrote: > > >> But wait. These are just local statics. Surelty you can put these into > >> struct ux500_msp instead? Here it looks like these will be used for > >> all ports, so MSP2 will enable the pins requested by MSP1 etc > >> completely broken. So put it into the struct ux500_msp state > >> container from ux500_msp_i2s.h where it belongs. > >> > >> Refer to drivers/tty/serial/amba-pl011.c when in trouble. This > >> one is a good pinctrl example. > > > > How do you see the MSP1 and MSP3 usage protection working if I hide it > > all away in MSP specific structs? > > Usage protection? Sorry not following. Please elaborate... Don't worry about it, I think I sorted it. Please see the lastest version of the patch (sent on 24th Aug). -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog