From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: George Zhang <georgezhang@vmware.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 01/11] vmci_context.patch: VMCI context list operations.
Date: Thu, 30 Aug 2012 13:57:29 -0700 [thread overview]
Message-ID: <20120830205729.GA3276@kroah.com> (raw)
In-Reply-To: <15333E71B3DDCB48A90165AD57993F285685DB43D7@exch-mbx-114.vmware.com>
On Thu, Aug 30, 2012 at 09:38:08AM -0700, George Zhang wrote:
> +/* VMCICptBufInfo: Used to set/get current context's checkpoint state. */
> +struct vmci_ctx_chkpt_buf_info {
> + uint64_t cptBuf;
> + uint32_t cptType;
> + uint32_t bufSize;
> + int32_t result;
> + uint32_t _pad;
> +};
Please use the proper kernel types when you are passing structures
across the kernel/user boundry (hint, you should NEVER be using the
uint*_t types in the kernel). You need to fix up all of the structures
that you pass through your ioctl, to use the correct __ types, and fix
up everything else to use the other types.
Also, you have a crazy variable naming scheme everywhere, remember, you
can use vowels and '_' characters :)
greg k-h
next prev parent reply other threads:[~2012-08-30 20:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120824171042.4775.36871.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:35 ` [Pv-drivers] [vmw_vmci 00/11] VMCI driver for Linux George Zhang
2012-08-30 16:35 ` George Zhang
[not found] ` <20120824171551.4775.87175.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:38 ` [PATCH 01/11] vmci_context.patch: VMCI context list operations George Zhang
2012-08-30 16:38 ` George Zhang
2012-08-30 20:57 ` gregkh [this message]
2012-08-30 21:05 ` gregkh
2012-08-30 21:05 ` gregkh
[not found] ` <20120824171556.4775.64978.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:39 ` [PATCH 02/11] vmci_datagram.patch: VMCI datagram entity handling George Zhang
2012-08-30 16:39 ` George Zhang
[not found] ` <20120824171607.4775.41134.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:40 ` [PATCH 04/11] vmci_driver.patch: VMCI device driver George Zhang
2012-08-30 21:04 ` gregkh
2012-08-30 16:40 ` George Zhang
[not found] ` <20120824171617.4775.63033.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:41 ` [PATCH 06/11] vmci_handle_array.patch: VMCI array of vmci_handle George Zhang
2012-08-30 16:41 ` George Zhang
[not found] ` <20120824171622.4775.49916.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:41 ` [PATCH 07/11] vmci_hash_table.patch: VMCI hash table implementation George Zhang
2012-08-30 16:41 ` George Zhang
[not found] ` <20120824171627.4775.50884.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:41 ` [PATCH 08/11] vmci_queue_pair.patch: VMCI queue pair implementation George Zhang
2012-08-30 16:41 ` George Zhang
[not found] ` <20120824171633.4775.49218.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:42 ` [PATCH 09/11] vmci_resource.patch: VMCI resource hash table implementation George Zhang
2012-08-30 16:42 ` George Zhang
[not found] ` <20120824171638.4775.22952.stgit@promb-2n-dhcp175.eng.vmware.com>
2012-08-30 16:42 ` [PATCH 10/11] vmci_route.patch: VMCI routing implementation George Zhang
2012-08-30 16:42 ` George Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830205729.GA3276@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=georgezhang@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.