From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] usb: ehci: rework to take advantage of new lowlevel interface
Date: Thu, 30 Aug 2012 23:09:27 +0200 [thread overview]
Message-ID: <201208302309.27159.marex@denx.de> (raw)
In-Reply-To: <1346342604-13355-3-git-send-email-dev@lynxeye.de>
Dear Lucas Stach,
> Kill off ehci-core.h
> It was used to specify some static controller data. To support more than
> one controller being active at any time we have to carry the controller
> data ourselfes. Change the ehci interface accordingly.
>
> NOTE: OMAP implemented the ehci stuff a bit backwards and should be fixed
> to do the same thing as other platforms. But the change for now is at least
> compile clean.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
[...]
The omap change could be separated out, no?
Also, I'd fix all these &(*something)->somethingelse if possible.
Otherwise,
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-08-30 21:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 16:03 [U-Boot] [PATCH 0/4] USB multi controller Lucas Stach
2012-08-30 16:03 ` [U-Boot] [PATCH 1/4] usb: lowlevel interface change to support multiple controllers Lucas Stach
2012-08-30 21:03 ` Marek Vasut
2012-08-30 16:03 ` [U-Boot] [PATCH 2/4] usb: ehci: rework to take advantage of new lowlevel interface Lucas Stach
2012-08-30 21:09 ` Marek Vasut [this message]
2012-08-30 21:51 ` Lucas Stach
2012-08-30 21:55 ` Marek Vasut
2012-08-30 16:03 ` [U-Boot] [PATCH 3/4] tegra20: port to new ehci interface Lucas Stach
2012-08-30 16:03 ` [U-Boot] [PATCH 4/4] usb: add support for multiple usb controllers Lucas Stach
2012-08-30 21:12 ` Marek Vasut
2012-09-04 23:05 ` [U-Boot] [PATCH 0/4] USB multi controller Stephen Warren
2012-09-05 0:30 ` Marek Vasut
2012-09-05 6:21 ` Lucas Stach
2012-09-05 6:30 ` Marek Vasut
2012-09-05 19:11 ` Stephen Warren
2012-09-05 19:27 ` Marek Vasut
2012-09-05 22:13 ` Lucas Stach
-- strict thread matches above, loose matches on Subject: below --
2012-09-25 22:14 Lucas Stach
2012-09-25 22:14 ` [U-Boot] [PATCH 2/4] usb: ehci: rework to take advantage of new lowlevel interface Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208302309.27159.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.