All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Kirkwood: Fix 'SZ_1M' undeclared here for db88f6281-bp-setup.c
Date: Fri, 31 Aug 2012 07:47:34 +0200	[thread overview]
Message-ID: <20120831054734.GA30111@lunn.ch> (raw)
In-Reply-To: <20120830185050.GZ19437@titan.lakedaemon.net>

On Thu, Aug 30, 2012 at 02:50:50PM -0400, Jason Cooper wrote:
> On Thu, Aug 30, 2012 at 08:08:53PM +0200, Andrew Lunn wrote:
> > On Thu, Aug 30, 2012 at 01:12:36PM -0400, Jason Cooper wrote:
> > > On Thu, Aug 30, 2012 at 07:39:12AM +0200, Andrew Lunn wrote:
> > > > Linux-next has failed to compile for kirkwood since 23 August with:
> > > > 
> > > > arch/arm/mach-kirkwood/db88f6281-bp-setup.c:29: error: 'SZ_1M' undeclared here (not in a function)
> > > > arch/arm/mach-kirkwood/db88f6281-bp-setup.c:33: error: 'SZ_4M' undeclared here (not in a function)
> > > > 
> > > > Add missing <linux/sizes.h>
> > > > 
> > > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > > 
> > > Applied to: fixes-for-v3.6
> > > 
> > > Also, I added a CC for stable so greg can pick it up.
> > 
> > Stable does not need it. As i said, it only broke 23 August with
> > linux-next. So this is needed for only 3.7.
> 
> Do we know caused the break?  Is it a fix destined for -stable?

Hi Jason

If im groking the output from gcc -E correctly, it was this change:

http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=8f039ba3191e67bf48e560f5737d0c285720d4d8

The #include <asm/memory.h> has been dropped, and its from there that
it was getting <linux/sizes.h>.

This does not look like a change that will get backported to anything
earlier than 3.7.

	Andrew

  parent reply	other threads:[~2012-08-31  5:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-30  5:39 [PATCH] ARM: Kirkwood: Fix 'SZ_1M' undeclared here for db88f6281-bp-setup.c Andrew Lunn
2012-08-30 17:12 ` Jason Cooper
2012-08-30 18:08   ` Andrew Lunn
2012-08-30 18:50     ` Jason Cooper
2012-08-30 18:59       ` Andrew Lunn
2012-08-31  5:47       ` Andrew Lunn [this message]
2012-08-31 15:38         ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831054734.GA30111@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.