Re: [RFC v2 PATCH 0/7] thp: transparent hugepages on s390

[Martin Schwidefsky <schwidefsky@de.ibm.com>]

On Thu, 30 Aug 2012 12:54:44 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 29 Aug 2012 17:32:57 +0200
> Gerald Schaefer <gerald.schaefer@de.ibm.com> wrote:
> 
> > This patch series adds support for transparent hugepages on System z.
> > Small changes to common code are necessary with regard to a different
> > pgtable_t, tlb flushing and kvm behaviour on s390, see patches 1 to 3.
> 
> "RFC" always worries me.  I read it as "Really Flakey Code" ;) Is it
> still appropriate to this patchset?

The code quality is IMHO already good. We do change common mm code though
and we want to get some feedback on that.

> I grabbed them all.  Patches 1-3 look sane to me and I cheerfully
> didn't read the s390 changes at all.  Hopefully Andrea will be able to
> review at least patches 1-3 for us.
> 
> If that all goes well, how do we play this?  I'd prefer to merge 1-3
> myself, as they do interact with ongoing MM development.  I can also
> merge 4-7 if appropriate s390 maintainer acks are seen.  Or I can drop
> them and the s390 parts can be merged via the s390 tree at a later
> date?

I would really appreciate if Andrea could have a look at the code. I've
read the patches and I am fine with them but it is very easy to miss some
important bit.

As far as upstreaming is concerned: I can deal with the pure s390 parts
via the s390 tree if that helps you. If you prefer the carry all of them,
that is fine with me as well.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.