From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] serial: atmel: add explict mach/gpio.h include
Date: Fri, 31 Aug 2012 16:45:06 +0200 [thread overview]
Message-ID: <20120831144506.GD23867@game.jcrosoft.org> (raw)
In-Reply-To: <504028CC.9020202@gmail.com>
On 22:00 Thu 30 Aug , Rob Herring wrote:
> On 08/29/2012 06:37 PM, Russell King - ARM Linux wrote:
> > On Wed, Aug 29, 2012 at 05:31:29PM -0500, Rob Herring wrote:
> >> From: Rob Herring <rob.herring@calxeda.com>
> >>
> >> In preparation to remove implicit inclusion of mach/gpio.h, add explicit
> >> include of mach/gpio.h.
> >
> > Definitely NAK.
> >
> > What is in the Atmel mach/gpio.h has hardly anything to do with the
> > gpio subsystem (it's more a private gpio implementation). It should
> > be renamed as such to make it clear (and so it doesn't trigger my
> > sanity filtering.)
>
> Jean-Christophe, Does your gpio clean-up address this?
yes I've a patch series on my local tree that cleanup this
on at91 we do not need the include/mach/gpio.h
and I do plan to drop most of the stuff in it
Best Regards,
J.
next prev parent reply other threads:[~2012-08-31 14:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 22:31 [PATCH 00/10] Make mach/gpio.h optional Rob Herring
2012-08-29 22:31 ` [PATCH 01/10] usb: pxa27x_udc: remove IRQ_USB define Rob Herring
2012-08-29 22:31 ` [PATCH 02/10] gpio: pxa: add explicit includes for cpu_is_X macros Rob Herring
2012-08-30 22:17 ` Linus Walleij
2012-09-03 3:19 ` Haojian Zhuang
2012-09-03 15:38 ` Rob Herring
2012-09-04 1:38 ` Haojian Zhuang
2012-08-29 22:31 ` [PATCH 03/10] serial: atmel: add explict mach/gpio.h include Rob Herring
2012-08-29 23:37 ` Russell King - ARM Linux
2012-08-31 3:00 ` Rob Herring
2012-08-31 14:45 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-08-31 4:12 ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-29 22:31 ` [PATCH 04/10] net: pxaficp_ir: add explicit mach/gpio.h includes Rob Herring
2012-08-29 22:31 ` [PATCH 05/10] ARM: at91: explicitly include mach/gpio.h Rob Herring
2012-08-30 17:14 ` Jean-Christophe PLAGNIOL-VILLARD
2012-08-30 17:24 ` Russell King - ARM Linux
2012-08-29 22:31 ` [PATCH 06/10] ARM: shmobile: " Rob Herring
2012-08-29 23:38 ` Russell King - ARM Linux
2012-08-29 22:31 ` [PATCH 07/10] ARM: orion: add explict mach/gpio.h includes Rob Herring
2012-08-29 22:31 ` [PATCH 08/10] ARM: omap2: " Rob Herring
2012-08-31 15:39 ` Tony Lindgren
2012-08-29 22:31 ` [PATCH 09/10] ARM: omap1: " Rob Herring
2012-08-29 22:31 ` [PATCH 10/10] ARM: make mach/gpio.h headers optional Rob Herring
2012-08-29 23:40 ` [PATCH 00/10] Make mach/gpio.h optional Russell King - ARM Linux
2012-08-30 15:27 ` Rob Herring
2012-08-30 16:52 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831144506.GD23867@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.