All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 02/10] xfstests: rename USE_BIG_LOOPFS to be more generic
Date: Sat, 1 Sep 2012 09:30:51 +1000	[thread overview]
Message-ID: <20120831233051.GE13691@dastard> (raw)
In-Reply-To: <503CCF3F.5050608@sgi.com>

On Tue, Aug 28, 2012 at 09:01:35AM -0500, Rich Johnston wrote:
> On 07/26/2012 03:39 AM, Dave Chinner wrote:
> >From: Dave Chinner <dchinner@redhat.com>
> >
> >USE_BIG_LOOPFS is really misnamed - it can be used on real devices just as
> >easily as loop devices. It really means we are testing a large scratch device
> >and that we should enable the special filesystem filling and checking options
> >that enable xfstests to be run sanely on large XFS filesystems.
> >
> >Signed-off-by: Dave Chinner <dchinner@redhat.com>
> >---
> >  004       |    2 +-
> >  015       |    2 +-
> >  030       |    2 +-
> >  031       |    2 +-
> >  032       |    2 +-
> >  033       |    4 ++--
> >  041       |    2 +-
> >  049       |    2 +-
> >  083       |    2 +-
> >  092       |    2 +-
> >  148       |    2 +-
> >  149       |    2 +-
> >  common    |    2 +-
> >  common.rc |   12 ++++++------
> >  setup     |    5 +++--
> >  15 files changed, 23 insertions(+), 22 deletions(-)
> >
> 
> >  MOUNT_OPTIONS="$MOUNT_OPTIONS -o inode64"
> >  _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
> >diff --git a/148 b/148
> >index 76cbf37..7bb1722 100755
> >--- a/148
> >+++ b/148
> >@@ -66,8 +66,8 @@ _check_ag()
> >  _supported_fs xfs
> >  _supported_os IRIX Linux
> 
> #RCJ As long as you are making changes to this file, please remove
> Linux from the _supported_os as xfs_prepair64 is an IRIX specific
> binary.

Such a change belongs in a separate patch, not intermingled with a
patch in a series that has nothing to do with xfs_prepair64....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-08-31 23:30 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120831194326.741195404@sgi.com>
2012-07-26  8:39 ` [PATCH 0/10] xfstests: rework large filesystem testing Dave Chinner
2012-07-26  8:39   ` [PATCH 01/10] xfstests: add --largefs check option Dave Chinner
2012-08-28 14:00     ` Rich Johnston
2012-08-28 19:56     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 02/10] xfstests: rename USE_BIG_LOOPFS to be more generic Dave Chinner
2012-08-28 14:01     ` Rich Johnston
2012-08-31 23:30       ` Dave Chinner [this message]
2012-08-28 19:56     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 03/10] xfstests: rename RETAIN_AG_BYTES Dave Chinner
2012-08-28 14:01     ` Rich Johnston
2012-08-28 19:56     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 04/10] xfstests: use preallocation for ag-wiper Dave Chinner
2012-08-28 14:02     ` Rich Johnston
2012-08-28 19:57     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 05/10] xfstests: use command line option for setting extra space Dave Chinner
2012-08-28 14:02     ` Rich Johnston
2012-08-28 19:57     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 06/10] xfstest: enable xfs_repair for large filesystem testing Dave Chinner
2012-08-28 14:02     ` Rich Johnston
2012-08-28 19:58     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 07/10] xfstests: always us test option when checking large scratch device Dave Chinner
2012-07-26 17:21     ` Paulo Alcantara
2012-08-28 14:02     ` Rich Johnston
2012-08-28 19:58     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 08/10] xfstests: enable large fs testing on ext4 Dave Chinner
2012-08-28 20:03     ` Christoph Hellwig
2012-09-05 16:27     ` Rich Johnston
2012-07-26  8:39   ` [PATCH 09/10] xfstests: disable tests that typically fail on large filesystems Dave Chinner
2012-08-28 14:03     ` Rich Johnston
2012-08-28 20:03     ` Christoph Hellwig
2012-07-26  8:39   ` [PATCH 10/10] xfstests: exclude largefs fill files from dump tests Dave Chinner
2012-08-28 14:03     ` Rich Johnston
2012-08-28 20:04     ` Christoph Hellwig
2012-08-14 21:40   ` [PATCH 0/10] xfstests: rework large filesystem testing Dave Chinner
2012-09-05 21:34   ` [PATCH 11/10] xfstests: rework large filesystem testing - add golden output Ben Myers
2012-09-05 22:26   ` Dave Chinner
2012-09-06 12:57     ` Rich Johnston
2012-09-06 23:07       ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831233051.GE13691@dastard \
    --to=david@fromorbit.com \
    --cc=rjohnston@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.