All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin McKinney <klmckinney1@gmail.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	ldv-project@ispras.ru
Subject: Re: [PATCH v2] staging: bcm: fix error handling in bcm_init()
Date: Sun, 2 Sep 2012 16:38:26 -0400	[thread overview]
Message-ID: <20120902203823.GB3952@gmail.com> (raw)
In-Reply-To: <1346614214-14340-1-git-send-email-khoroshilov@ispras.ru>

On Sun, Sep 02, 2012 at 11:30:13PM +0400, Alexey Khoroshilov wrote:
> bcm_init() does not have proper error handling of usb_register().
> The patch implements one.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>  drivers/staging/bcm/InterfaceInit.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c
> index 8f85de6..57452ef 100644
> --- a/drivers/staging/bcm/InterfaceInit.c
> +++ b/drivers/staging/bcm/InterfaceInit.c
> @@ -669,6 +669,8 @@ struct class *bcm_class;
>  
Acked-by: Kevin McKinney <klmckinney1@gmail.com>

      parent reply	other threads:[~2012-09-02 20:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-01 21:37 [PATCH] staging: bcm: fix error handling in bcm_init() Alexey Khoroshilov
2012-09-02 16:51 ` Kevin McKinney
2012-09-02 19:30   ` [PATCH v2] " Alexey Khoroshilov
2012-09-02 19:30     ` [PATCH] staging: bcm: use pr_info and pr_err rather than printk Alexey Khoroshilov
2012-09-02 20:42       ` Kevin McKinney
2012-09-02 20:38     ` Kevin McKinney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120902203823.GB3952@gmail.com \
    --to=klmckinney1@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.