From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
Sami Farin <hvtaifwkbgefbaei@gmail.com>,
netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH v2] netfilter: take care of timewait sockets
Date: Mon, 3 Sep 2012 09:47:18 +0200 [thread overview]
Message-ID: <20120903074718.GA14750@breakpoint.cc> (raw)
In-Reply-To: <1346629684.2563.78.camel@edumazet-glaptop>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Sami Farin reported crashes in xt_LOG because it assumes skb->sk is a
> full blown socket.
>
> But with TCP early demux, we can have skb->sk pointing to a timewait
> socket.
>
> Same fix is needed in netfnetlink_log
Looks good, but IMHO it is very un-intuitive that
skb->sk might be a pointer to an object that is not struct sock (or
a compatible object).
next prev parent reply other threads:[~2012-09-03 7:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 13:49 (ipt_log_packet, sb_add) 3.6.0-rc2 kernel panic - not syncing; Fatal exception in interrupt Sami Farin
2012-09-02 12:20 ` Sami Farin
2012-09-02 13:28 ` Florian Westphal
2012-09-02 13:45 ` Sami Farin
2012-09-02 22:53 ` Eric Dumazet
2012-09-02 23:37 ` Eric Dumazet
2012-09-02 23:48 ` [PATCH v2] netfilter: take care of timewait sockets Eric Dumazet
2012-09-03 7:47 ` Florian Westphal [this message]
2012-09-03 9:57 ` Eric Dumazet
2012-09-03 17:23 ` David Miller
2012-09-04 7:55 ` Eric Dumazet
2012-09-04 16:16 ` David Miller
2012-09-14 9:30 ` Sami Farin
2012-09-10 5:02 ` (ipt_log_packet, sb_add) 3.6.0-rc2 kernel panic - not syncing; Fatal exception in interrupt Jan Engelhardt
2012-09-10 6:00 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903074718.GA14750@breakpoint.cc \
--to=fw@strlen.de \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eric.dumazet@gmail.com \
--cc=hvtaifwkbgefbaei@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.