From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Some doubts with fancontrol
Date: Mon, 03 Sep 2012 15:55:27 +0000 [thread overview]
Message-ID: <20120903155527.GA6274@roeck-us.net> (raw)
In-Reply-To: <504241C4.30701@fastmail.fm>
On Mon, Sep 03, 2012 at 09:36:48AM +0200, Jean Delvare wrote:
> Adding Henrique to Cc.
>
[ ... ]
> >
> > See above. It can not select 2, since values above 1 are driver and hardware
> > specific. fancontrol does not know about specific hardware and has to play it
> > safe. Which, again, is to select manual mode and the fastest available fan
> > speed.
>
> That's indeed the logic behind the current implementation. That being
> said, while the fancontrol script cannot switch to pwmN_enable=2
> unconditionally, we could make it remember the pwmN_enable values when
> it starts, and restore these values at exit if they are 2 or above.
> Guenter, what do you think?
>
Yes, that would be good idea. After all, it is what we are trying to do in at
least some of the drivers. To be on the safe side, we should probably safe
and restore both the pwm value and and pwm_enable.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-09-03 15:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-01 17:11 [lm-sensors] Some doubts with fancontrol Francesco Turco
2012-09-02 17:32 ` Guenter Roeck
2012-09-03 7:36 ` Jean Delvare
2012-09-03 10:35 ` Francesco Turco
2012-09-03 10:38 ` Francesco Turco
2012-09-03 15:55 ` Guenter Roeck [this message]
2012-09-03 18:48 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903155527.GA6274@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.