From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 3 Sep 2012 20:10:45 +0000 Subject: [PATCH 2/6 v3] ARM: integrator: check PL010 base address from resource In-Reply-To: <1346702775-19828-1-git-send-email-linus.walleij@linaro.org> References: <1346702775-19828-1-git-send-email-linus.walleij@linaro.org> Message-ID: <201209032010.46141.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 03 September 2012, Linus Walleij wrote: > In the PL010 UART callback a comparison against the location of the > statically allocated PL010 device is done to figure out which UART > is doing the callback. This does not play well with dynamic devices > such as in device tree, so let's check the base address of the > memory resource inside the amba_device instead. > > Signed-off-by: Linus Walleij > --- > ChangeLog v2->v3: > - Check for the base address of the physical memory resource instead > of checking for the device name (which will also be dynamic when > we use device tree). Ok, looks good to me. Acked-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/6 v3] ARM: integrator: check PL010 base address from resource Date: Mon, 3 Sep 2012 20:10:45 +0000 Message-ID: <201209032010.46141.arnd@arndb.de> References: <1346702775-19828-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1346702775-19828-1-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Linus Walleij Cc: Russell King , Pawel Moll , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Will Deacon , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday 03 September 2012, Linus Walleij wrote: > In the PL010 UART callback a comparison against the location of the > statically allocated PL010 device is done to figure out which UART > is doing the callback. This does not play well with dynamic devices > such as in device tree, so let's check the base address of the > memory resource inside the amba_device instead. > > Signed-off-by: Linus Walleij > --- > ChangeLog v2->v3: > - Check for the base address of the physical memory resource instead > of checking for the device name (which will also be dynamic when > we use device tree). Ok, looks good to me. Acked-by: Arnd Bergmann