From: Stephen Hemminger <shemminger@vyatta.com>
To: y@redhat.com
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Dan Kenigsberg <danken@redhat.com>
Subject: Re: [iproute2][PATCH v2] tc: mirred target: do not report non-existing devices
Date: Tue, 4 Sep 2012 08:40:29 -0700 [thread overview]
Message-ID: <20120904084029.04ffeae0@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1346582882-14568-1-git-send-email-y>
On Sun, 2 Sep 2012 13:48:02 +0300
y@redhat.com wrote:
> From: Dan Kenigsberg <danken@redhat.com>
>
> Currently, if a mirred target device is removed, `tc filter show`
> does not reveal the fact. Instead, it replaces the original name of the
> device with the default output of ll_map:ll_idx_n2a().
>
> This is unfortunate, since one cannot differ between this case and a valid
> mirroring target device named 'if17'.
>
> It seems that the original code meant to report an error message in this
> case, but it does not, since ll_index_to_name() never returns 0. I would
> not like to bail out in case of an error, since the user would still be
> interested to know what are the other details of the action.
>
> v2: properly declare the new function ll_index_exsits()
I am okay with the concept but "missing-if1" is still a possible
but unlikely name for a device. Maybe better to use something more
obvious like [unknown-1] or UNKNOWN?
prev parent reply other threads:[~2012-09-04 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 14:51 [iproute2][PATCH] tc: mirred target: do not report non-existing devices Dan Kenigsberg
2012-08-30 15:01 ` Eric Dumazet
2012-09-02 10:41 ` Dan Kenigsberg
2012-09-02 10:48 ` [iproute2][PATCH v2] " y
[not found] ` <1346582882-14568-1-git-send-email-y>
2012-09-04 15:40 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904084029.04ffeae0@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=danken@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=y@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.