From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: Xen4.2 S3 regression?
Date: Tue, 4 Sep 2012 10:36:18 -0400
Message-ID: <20120904143618.GB23361@phenom.dumpdata.com>
References: <CAOvdn6VD6bp13F-tvYdkBsj4hkhE7PTGZrapndtdHrDKeZqccg@mail.gmail.com>
	<502CCC0002000078000955C4@nat28.tlf.novell.com>
	<CAOvdn6VEuX7R2_wz74ZvCxMjC-=YUir9kP5sdxEVaKVspRUd_w@mail.gmail.com>
	<502CF0A8020000780009574E@nat28.tlf.novell.com>
	<CAOvdn6VsZvn_1TCWYeuyY5YuTcP8=miK2KwE4583nsj6Qjb_vg@mail.gmail.com>
	<504494FB0200007800098398@nat28.tlf.novell.com>
	<CAOvdn6UT13qvWbMyfZkWND03RoVKVSgb6wW4yqTUpuBYEX01Dg@mail.gmail.com>
	<CAOvdn6W+XZiiJyUb04WwMEh+WFB5Dam+NLpKa1DuTCGLU=BuaA@mail.gmail.com>
	<50462B9D02000078000987A4@nat28.tlf.novell.com>
	<27134645888804121@unknownmsgid>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <27134645888804121@unknownmsgid>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ben Guthro <ben.guthro@gmail.com>
Cc: Thomas Goetz <thomas.goetz@citrix.com>, xen-devel <xen-devel@lists.xen.org>, Ben Guthro <ben@guthro.net>, Jan Beulich <JBeulich@suse.com>, "john.baboval@citrix.com" <john.baboval@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Sep 04, 2012 at 10:28:37AM -0400, Ben Guthro wrote:
> How is it that it works with an older hypervisor, then?
> 
> Konrad - is the v7 code functionally different than the v10 code, or
> is it more  stylistic changes?

It is that v3.4 (and up) already has the restore_MSI hypervisor call:

commit 8605c6844fb9bdf55471bb87c3ac62d44eb34e04
Author: Tang Liang <liang.tang@oracle.com>
Date:   Thu Dec 8 17:36:39 2011 +0800

    xen: Utilize the restore_msi_irqs hook.
    
    to make a hypercall to restore the vectors in the MSI/MSI-X
    configuration space.
    
    Signed-off-by: Tang Liang <liang.tang@oracle.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

The only part that is left out of mainline is the part where the hypercall
is done properly. That is what the acpi/s3.v10 does.. but after talking to
Len he pointed out a different way of doing this.

> 
> On Sep 4, 2012, at 10:25 AM, Jan Beulich <JBeulich@suse.com> wrote:
> 
> >>>> On 04.09.12 at 14:49, Ben Guthro <ben@guthro.net> wrote:
> >> I forgot to address your dom0 kernel concern -
> >>
> >> All of these tests have been run with Konrad Wilk's acpi-s3.vX branches.
> >>
> >> The later kernels took more recent branches, while the 3.2.yy kernels
> >> used an older (but still functional) branch (acpi-s3.v7)
> >
> > This and the log you provided suggest that your kernel is lacking
> > the MSI restore code altogether (or it is not getting called as
> > intended). With that, there's pretty little point in continuing
> > the investigation on the hypervisor side.
> >
> > Jan
> >