From: Andrew Morton <akpm@linux-foundation.org>
To: yan yan <clouds.yan@gmail.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] proc: return -ENOMEM when inode allocation failed
Date: Tue, 4 Sep 2012 15:41:43 -0700 [thread overview]
Message-ID: <20120904154143.f6bcbdb4.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAH+=+MG=9189mS7+Cb85-PV51EX1Df-zGmZ3u4YtSsEfmphYUQ@mail.gmail.com>
On Tue, 4 Sep 2012 17:22:15 +0800
yan yan <clouds.yan@gmail.com> wrote:
> 2012/9/4 Cong Wang <xiyou.wangcong@gmail.com>:
> > On 09/03/2012 10:14 PM, yan wrote:
> >>
> >> Signed-off-by: yan <clouds.yan@gmail.com>
> >
> >
> > Please provide a changelog to explain why we need this patch.
>
> I think the title is self explained.
Given this review feedback, the title alone was obviously insufficient!
I provided the following changelog text:
: If proc_get_inode() returns NULL then presumably it encountered memory
: exhaustion. proc_lookup_de() should return -ENOMEM in this case, not
: -EINVAL.
next prev parent reply other threads:[~2012-09-04 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 14:14 [PATCH 0/3] Trivial code clean for procfs yan
2012-09-03 14:14 ` [PATCH 1/3] proc: return -ENOMEM when inode allocation failed yan
2012-09-04 0:38 ` Ryan Mallon
2012-09-04 3:02 ` Cong Wang
2012-09-04 9:22 ` yan yan
2012-09-04 22:41 ` Andrew Morton [this message]
2012-09-05 7:15 ` Cong Wang
2012-09-05 7:57 ` yan yan
2012-09-03 14:14 ` [PATCH 2/3] proc : no need to initialize proc_inode->fd in proc_get_inode yan
2012-09-04 22:49 ` Andrew Morton
2012-09-03 14:14 ` [PATCH 3/3] proc: use kzalloc instead of kmalloc and memset yan
2012-09-04 0:44 ` Ryan Mallon
2012-09-04 9:10 ` yan yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904154143.f6bcbdb4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clouds.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.