From: Ben Myers <bpm@sgi.com>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 0/5] Use libtool to install apps and remove relative lib paths
Date: Tue, 4 Sep 2012 11:07:06 -0500 [thread overview]
Message-ID: <20120904160706.GJ3274@sgi.com> (raw)
In-Reply-To: <20120828172605.607853317@sgi.com>
Hey Rich,
On Tue, Aug 28, 2012 at 12:26:05PM -0500, Rich Johnston wrote:
> This 5 part patchset (for xfstests, dmapi and xfsdump):
>
> 1. Uses libtool to install the binary from the proper location and display a
> warning if any shared library dependancies are not properly installed.
> 2. Ensures that a libtool wrapper shell script is not installed in place of
> the application when libtool wrappers are being used.
> 3. Removes the undocumented feature which allowed xfs developers to build and
> run xfstests without having to install the libraries. This can lead to
> touble if you expect that xfstests is using the versions of the libraries
> installed on the system.
This patchset looks great to me.
Although Dave has mentioned that the first patch probably isn't strictly
necessary... I think that it's worth pulling in. Since we build with libtool
we should also install with libtool.
Dave also asked about dmapi. I took a brief look at the dmapi Makefiles. It
appears the library is already installed using INSTALL_LTLIB.
Looks good!
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-04 16:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 17:26 [PATCH 0/5] Use libtool to install apps and remove relative lib paths Rich Johnston
2012-08-28 17:26 ` [PATCH 1/5] xfstests: Use libtool to install lstat64 Rich Johnston
2012-09-03 5:31 ` Dave Chinner
2012-08-28 17:26 ` [PATCH 2/5] xfstests: Use libtool to install applications Rich Johnston
2012-09-03 5:36 ` Dave Chinner
2013-04-16 15:54 ` Boris Ranto
2013-04-17 14:51 ` Rich Johnston
2013-04-17 15:56 ` Eric Sandeen
2013-04-18 12:25 ` Boris Ranto
2013-04-18 12:46 ` Greg Freemyer
2013-04-18 13:37 ` Boris Ranto
2012-08-28 17:26 ` [PATCH 3/5] xftests: Use installed libraries only Rich Johnston
2012-09-03 5:37 ` Dave Chinner
2012-08-28 17:26 ` [PATCH 4/5] dmapi: " Rich Johnston
2012-09-03 5:38 ` Dave Chinner
2012-08-28 17:26 ` [PATCH 5/5] xfsdump: " Rich Johnston
2012-09-03 5:39 ` Dave Chinner
2012-09-04 16:07 ` Ben Myers [this message]
2012-09-06 18:43 ` [PATCH 0/5] Use libtool to install apps and remove relative lib paths Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904160706.GJ3274@sgi.com \
--to=bpm@sgi.com \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.