From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Toshiaki Yamane <yamanetoshi@gmail.com>
Cc: devel@driverdev.osuosl.org,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-kernel@vger.kernel.org, Martyn Welch <martyn.welch@ge.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 2/3] staging/vme: Use pr_ printks in vme_user.c
Date: Tue, 4 Sep 2012 13:20:53 -0700 [thread overview]
Message-ID: <20120904202053.GA23449@kroah.com> (raw)
In-Reply-To: <1345547573-13371-1-git-send-email-yamanetoshi@gmail.com>
On Tue, Aug 21, 2012 at 08:12:53PM +0900, Toshiaki Yamane wrote:
> The below checkpatch warnings was fixed,
>
> -WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
> -WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
> -WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
> -WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
>
> and added pr_fmt.
A lot of these can be converted to use dev_info(), dev_debug(),
dev_warn(), and dev_err() instead. Please do that whenever you have
access to a struct device.
So, sorry, I can't take this patch.
greg k-h
next prev parent reply other threads:[~2012-09-04 20:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 13:00 [PATCH] staging/vme: fix checkpatch warnings Toshiaki Yamane
2012-07-23 0:53 ` Toshiaki Yamane
2012-08-17 5:04 ` [PATCH 1/5] staging/vme: fix checkpatch error Toshiaki Yamane
2012-08-17 5:05 ` [PATCH 2/5] staging/vme: fix checkpatch warning Toshiaki Yamane
2012-08-17 7:46 ` Dan Carpenter
2012-08-17 8:27 ` Toshiaki Yamane
2012-08-17 13:19 ` Greg Kroah-Hartman
2012-08-17 14:30 ` Toshiaki Yamane
2012-08-21 11:11 ` Toshiaki Yamane
2012-08-21 11:12 ` [PATCH 1/3] Staging: vme: Fix a white space issue Toshiaki Yamane
2012-08-21 11:12 ` [PATCH 2/3] staging/vme: Use pr_ printks in vme_user.c Toshiaki Yamane
2012-09-04 20:20 ` Greg Kroah-Hartman [this message]
2012-09-11 7:16 ` [PATCH 1/2] " Toshiaki Yamane
2012-09-11 7:17 ` [PATCH 2/2] staging/vme: Use dev_ " Toshiaki Yamane
2012-09-11 19:08 ` Greg Kroah-Hartman
2012-09-11 19:08 ` [PATCH 1/2] staging/vme: Use pr_ " Greg Kroah-Hartman
2012-09-12 7:36 ` Toshiaki Yamane
2012-09-12 14:04 ` Greg Kroah-Hartman
2012-08-21 11:13 ` [PATCH 3/3] staging/vme: Use pr_ printks in vme_pio2_core.c Toshiaki Yamane
2012-08-17 5:05 ` [PATCH 3/5] staging/vme: fix checkpatch warning Toshiaki Yamane
2012-08-17 5:05 ` [PATCH 4/5] " Toshiaki Yamane
2012-08-17 5:06 ` [PATCH 5/5] " Toshiaki Yamane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904202053.GA23449@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn.welch@ge.com \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.