From: Theodore Ts'o <tytso@mit.edu>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: Anssi Hannula <anssi.hannula@iki.fi>,
Kevin Liao <kevinlia@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/2] resize2fs: fix overhead calculation for meta_bg file systems
Date: Wed, 5 Sep 2012 01:38:15 -0400 [thread overview]
Message-ID: <20120905053815.GB29950@thunk.org> (raw)
In-Reply-To: <CAGBYx2YgL6h2-EfHKrWe7dMXjS2u7a=F39gCL3VeCjJKFDYq7A@mail.gmail.com>
BTW, it looks like your 2/2 patch does not have a dependency on the
rest of the resize patches, and fixes a problem which exists today
with the flex_bg resizing. So you'll see I moved it to the beginning
of the patch series, and added a "Cc: stable@vger.kernel.org", since
it's a patch that should be backported to older stable kernels.
This kind of applicability statement is helpful for me, since I don't
have to try to figure it out (and because I might get it wrong as I
try to figure out the reasoning behind a patch, and the priority of
the patch). Things that are useful to include is whether it is fixing
a recent regression, or if it is fixing a bug that is in older
kernels, how long has the bug been present, so we know which older
kernels need the patch, and in particular, whether enterprise
distributions need to worry about backporting the patch.
And as I mentioned earlier, if it causes user data loss/corruption, or
causes the kernel to crash, please make a note of this in the commit
description, since that's also important information when trying to
decide if a patch needs priority handling or needs to be backported to
older stable kernels.
Thanks, regards,
- Ted
next prev parent reply other threads:[~2012-09-05 5:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 9:52 [PATCH] resize2fs: support online-resizing for meta_bg and 64bits features Yongqiang Yang
2012-09-02 10:31 ` Yongqiang Yang
2012-09-03 0:50 ` Theodore Ts'o
2012-09-03 16:45 ` Theodore Ts'o
2012-09-03 16:45 ` [PATCH 1/2] resize2fs: allow meta_bg/64-bit file systems to be online resized Theodore Ts'o
2012-09-03 16:45 ` [PATCH 2/2] resize2fs: fix overhead calculation for meta_bg file systems Theodore Ts'o
2012-09-04 1:59 ` Yongqiang Yang
2012-09-04 2:14 ` Kevin Liao
2012-09-04 2:14 ` Theodore Ts'o
2012-09-04 17:05 ` Anssi Hannula
2012-09-05 2:10 ` Yongqiang Yang
2012-09-05 4:55 ` Theodore Ts'o
2012-09-05 5:16 ` Yongqiang Yang
2012-09-05 5:38 ` Theodore Ts'o [this message]
2012-09-06 14:22 ` Anssi Hannula
2012-09-06 16:19 ` Yongqiang Yang
2012-09-05 6:32 ` Kevin Liao
2012-09-05 6:44 ` Yongqiang Yang
2012-09-05 6:50 ` Kevin Liao
2012-09-13 23:21 ` Theodore Ts'o
2012-09-14 3:24 ` Kevin Liao
2012-09-04 2:02 ` Yongqiang Yang
2012-09-03 21:02 ` [PATCH] resize2fs: support online-resizing for meta_bg and 64bits features Kai Grosshaus
2012-09-03 23:00 ` Theodore Ts'o
2012-09-03 23:33 ` Kai Großhaus
2012-09-04 2:01 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905053815.GB29950@thunk.org \
--to=tytso@mit.edu \
--cc=anssi.hannula@iki.fi \
--cc=kevinlia@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.