All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Shi, Yang A" <yang.a.shi@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>,
	"Liu, Chuansheng" <chuansheng.liu@intel.com>,
	"'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org)"
	<linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
	"airlied@redhat.com" <airlied@redhat.com>
Subject: Re: [Patch 0/1]drm_irq: Introducing the irq_thread support
Date: Wed, 5 Sep 2012 17:32:04 +0200	[thread overview]
Message-ID: <20120905153204.GD5357@phenom.ffwll.local> (raw)
In-Reply-To: <E3ED5BF57CCD1C40876FA2D3385ED5D30FD781AC@SHSMSX102.ccr.corp.intel.com>

On Wed, Sep 05, 2012 at 03:12:39PM +0000, Shi, Yang A wrote:
> Hi Vetter:
> 
>     Do you mean we can just not use drm_irq_install, and make
>     request_irq in our kernel driver pre-install or post-install
>     interface?

Well, you cant use the pre_install/post_install hooks the drm_irq code
provides, but yes, just do the request_irq in your driver code at the
right time, with the right parameters. Much easier than adding code to a
part of the drm core fraught with backwards-compat stuff no one really
wants to touch ... All the additional stuff besides calling request_irq
and the driver hooks that drm_irq_install does is really just to support
old dri1 userspace.

Yours, Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48

  reply	other threads:[~2012-09-05 15:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-05  1:53 [Patch 0/1]drm_irq: Introducing the irq_thread support Liu, Chuansheng
2012-09-05 12:49 ` Alan Cox
2012-09-06  0:42   ` Liu, Chuansheng
2012-09-06  7:39     ` Daniel Vetter
2012-09-05 13:27 ` Daniel Vetter
2012-09-05 15:12   ` Shi, Yang A
2012-09-05 15:32     ` Daniel Vetter [this message]
2012-09-06  0:54       ` Liu, Chuansheng
2012-09-05 15:47   ` Rob Clark
2012-09-06  0:48   ` Liu, Chuansheng
2012-10-11 12:07   ` Laurent Pinchart
2012-10-11 13:19     ` Rob Clark
2012-10-11 13:19       ` Rob Clark
2012-10-11 15:18       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120905153204.GD5357@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=chuansheng.liu@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yang.a.shi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.