From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] perf: remove unneeded include of network header files
Date: Wed, 5 Sep 2012 15:37:39 -0700 [thread overview]
Message-ID: <20120905223739.GE8203@ghostprotocols.net> (raw)
In-Reply-To: <5047C18B.9060602@gmail.com>
Em Wed, Sep 05, 2012 at 03:18:03PM -0600, David Ahern escreveu:
> On 9/5/12 2:39 PM, Arnaldo Carvalho de Melo wrote:
> >Em Wed, Aug 29, 2012 at 09:55:32AM -0600, David Ahern escreveu:
> >>perf does not have networking related functionality, and the inclusion of
> >>these headers is one of the causes of compile failures for Android:
> >> https://lkml.org/lkml/2012/8/23/316
> >> https://lkml.org/lkml/2012/8/28/293
> >>
> >>So, remove them.
> >>
> >>Signed-off-by: David Ahern <dsahern@gmail.com>
> >>Cc: Ingo Molnar <mingo@kernel.org>
> >>Cc: Frederic Weisbecker <fweisbec@gmail.com>
> >>Cc: Peter Zijlstra <peterz@infradead.org>
> >
> > CC /home/acme/git/build/perf/util/scripting-engines/trace-event-python.o
> >In file included from /usr/lib64/perl5/CORE/perl.h:1239,
> > from util/scripting-engines/trace-event-perl.c:36:
> >/usr/include/netdb.h:591: error: expected identifier or ‘(’ before ‘[’ token
> >make: *** [/home/acme/git/build/perf/util/scripting-engines/trace-event-perl.o] Error 1
> >make: *** Waiting for unfinished jobs....
> >make: Leaving directory `/home/git/linux/tools/perf'
>
> grr... removed the perl package testing the kconfig integration.
> forgot to reinstall. Will update.
>
I fixed it already, nevermind, it was just a matter of reordering
includes, think how fragil that is, but it works now.
- Arnaldo
next prev parent reply other threads:[~2012-09-05 22:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 15:55 [PATCH] perf: remove unneeded include of network header files David Ahern
2012-09-05 20:39 ` Arnaldo Carvalho de Melo
2012-09-05 21:18 ` David Ahern
2012-09-05 22:37 ` Arnaldo Carvalho de Melo [this message]
2012-09-05 23:06 ` David Ahern
2012-09-07 6:05 ` [tip:perf/core] perf tools: " tip-bot for David Ahern
-- strict thread matches above, loose matches on Subject: below --
2012-09-05 21:53 [PATCH] perf: " David Ahern
2012-09-05 22:40 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905223739.GE8203@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.