From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] Commit 67cbbf2... breaks some ARM builds
Date: Thu, 6 Sep 2012 09:49:17 +0200 [thread overview]
Message-ID: <20120906094917.34bf8247@lilith> (raw)
Hello,
While merging u-boot/master and u-boot-arm/master in preparation of a
pull requst, I saw that commit 67cbbf2... ("mmc: Remove unused item
flags in struct mmc_cmd") breaks several arm builds such as palmld:
$ LANG=C ./MAKEALL palmld
Configuring for palmld board...
pxa_mmc_gen.c:121:9: error: 'struct mmc_cmd' has no member named 'flags'
pxa_mmc_gen.c:184:47: error: 'struct mmc_cmd' has no member named
'flags'
pxa_mmc_gen.c:186:10: error: 'struct mmc_cmd' has no member named
'flags'
make[1]: *** [pxa_mmc_gen.o] Error 1
make: *** [drivers/mmc/libmmc.o] Error 2
arm-linux-gnueabi-size: './u-boot': No such file
pxa_mmc_gen.c: In function 'pxa_mmc_start_cmd':
pxa_mmc_gen.c:121:9: error: 'struct mmc_cmd' has no member named 'flags'
pxa_mmc_gen.c: In function 'pxa_mmc_cmd_done':
pxa_mmc_gen.c:184:47: error: 'struct mmc_cmd' has no member named
'flags'
pxa_mmc_gen.c:186:10: error: 'struct mmc_cmd' has no member named
'flags'
make[1]: *** [pxa_mmc_gen.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers/mmc/libmmc.o] Error 2
make: *** Waiting for unfinished jobs....
--------------------- SUMMARY ----------------------------
Boards compiled: 1
Boards with errors: 1 ( palmld )
----------------------------------------------------------
Apparently, either the commit overlooked some ARM boards when
considering 'flags' were unused, or it did not remove all references to
flags throughout the code base.
Kapster, can you post a fix or revert?
Amicalement,
--
Albert.
reply other threads:[~2012-09-06 7:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906094917.34bf8247@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.