From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Shi <alex.shi@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, cpw@sgi.com,
steiner@sgi.com, jeremy.fitzhardinge@citrix.com,
linux-kernel@vger.kernel.org, jbeulich@suse.com
Subject: Re: [PATCH] UV: fix incorrect tlb flush all issue
Date: Thu, 6 Sep 2012 16:11:36 -0700 [thread overview]
Message-ID: <20120906161136.b15e3d91.akpm@linux-foundation.org> (raw)
In-Reply-To: <1345798655-3669-1-git-send-email-alex.shi@intel.com>
On Fri, 24 Aug 2012 16:57:35 +0800
Alex Shi <alex.shi@intel.com> wrote:
> The flush tlb optimization code has logical issue on UV platform.
> It doesn't flush the full range at all, since it simply
> ignores its 'end' parameter (and hence also the "all" indicator)
> in uv_flush_tlb_others() function.
>
> This patch fixed this issue, but untested due to hardware leaking.
Well, it doesn't really come very close to being compilable:
arch/x86/platform/uv/tlb_uv.c: In function 'bau_process_message':
arch/x86/platform/uv/tlb_uv.c:283: error: 'struct bau_pq_entry' has no member named 'end'
arch/x86/platform/uv/tlb_uv.c:284: error: 'struct bau_pq_entry' has no member named 'start'
Cliff, could you please help out here?
next prev parent reply other threads:[~2012-09-06 23:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 8:57 [PATCH] UV: fix incorrect tlb flush all issue Alex Shi
2012-09-06 23:11 ` Andrew Morton [this message]
2012-09-07 5:37 ` Alex Shi
2012-09-07 7:10 ` Jan Beulich
2012-09-10 2:07 ` Alex Shi
-- strict thread matches above, loose matches on Subject: below --
2012-09-25 12:34 Cliff Wickman
2012-09-26 11:23 ` Ingo Molnar
2012-09-26 22:30 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906161136.b15e3d91.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=cpw@sgi.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.